Landing Recent QUIC changes until 2016-03-15 16:26 UTC

Landing Recent QUIC changes until 2016-03-15 16:26 UTC
Up to and including internal change 117245736

Fix a type casting bug in quic stream sequencer buffer.

Withough this change, a QUIC frame with offset higher than 2^32 might corrupt StreamSequencerBuffer's missing frame recording logic in a 32-bit machine.

Merge internal change: 117245736
https://codereview.chromium.org/1808013003/

Always use recvmmsg or recvmsg if it's available, and consolidate ReadAndDispatchPackets and ReadAndDispatchSinglePacket into a single API. Not flag protected. No functional change.

Note that this does somewhat reduce the test coverage of QuicServerTest, now
requiring that changes to QuicPacketReader::ReadAndDispatchSinglePacket be run
on platforms that don't support recvmmsg.

Merge internal change: 117245279
https://codereview.chromium.org/1810103002/

Log when client nonce is invalid. No functional change. Not flag protected.

Merge internal change: 116987771
https://codereview.chromium.org/1810073002/

Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag protected. No functional change.

Merge internal change: 116973081
https://codereview.chromium.org/1809123002/

Change QUIC tests that use port 80 to use 443.

Merge internal change: 116970314
https://codereview.chromium.org/1808963003/

Use byte conservation instead of packet conservation in QUIC's Slow Start Large Recovery experiment. Protected by quic_sslr_byte_conservation.

Merge internal change: 116964633
https://codereview.chromium.org/1814873002/

Remove the unused has_retransmittable_data argument from QuicSendAlgorithm::TimeUntilSend.  No functional change.  Not flag protected.

Merge internal change: 116904472
https://codereview.chromium.org/1814843002/

Deprecates check_peer_address_change_after_decryption.

Merge internal change: 116887287
https://codereview.chromium.org/1808613003/

Deprecate quic_respect_send_alarm2.

Merge internal change: 116879870
https://codereview.chromium.org/1813513002/

Deprecate --quic_include_path_id_in_iv.

Merge internal change: 116877752
https://codereview.chromium.org/1810743002/

Don't copy the QuicAckFrame into the QuicPacketGenerator.  Protected by quic_dont_copy_acks.

Merge internal change: 116808648
https://codereview.chromium.org/1807033002/

No longer limit QUIC's max CWND to 200 packets.  Protected by quic_dont_limit_max_cwnd.

This is a fix for the deprecation of a similar flag in cr/113769379.

Merge internal change: 116794514
https://codereview.chromium.org/1812633002/

Remove QuicFrameList, because it's unused with the new QuicStreamSequencer.

Merge internal change: 116768420
https://codereview.chromium.org/1805323003/

Add a QuicConfig option to ask the client not to attempt migration.

Merge internal change: 116712124
https://codereview.chromium.org/1808513003/

Do not disable TLP by default in QuicConnection tests.

Merge internal change: 116698228
https://codereview.chromium.org/1808863002/

Add a new QUIC connection option, 5RTO, which closes the QUIC connection after 5 consecutive RTOs. Protected by quic_enable_rto_timeout.

Merge internal change: 116687954
https://codereview.chromium.org/1806083002/

Change QuicConnection's ScopedPacketBundler to use SEND_QUEUED_ACK instead of NO_ACK, to ensure a queued ack is always sent.  Small functional change.  Not flag protected.

Merge internal change: 116677107
https://codereview.chromium.org/1814483002/

deprecate quic_use_rfc7539

Merge internal change: 116589902
https://codereview.chromium.org/1809703002/

Use cached compressed certs if available to reduce load of compressing certs. Flag protected by quic_use_cached_compressed_certs.

Merge internal change: 116579250.
https://codereview.chromium.org/1808793002/

R=rch@chromium.org
BUG=

Committed: https://crrev.com/f57804c4c8609f1c6c396eddb6a3174d2003362c
Cr-Commit-Position: refs/heads/master@{#381795}

[Ryan Hamilton, 2016-03-17 17:44:34]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-03-17 17:44:35]

lgtm

[commit-bot: I haz the power, 2016-03-17 17:44:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811043002/1

[commit-bot: I haz the power, 2016-03-17 17:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 17:51:23]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[fnk, 2016-03-17 18:05:41]

The CQ bit was checked by fnk@chromium.org

[fnk, 2016-03-17 18:05:42]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1811043002/#ps20001
(title: "Deprecate quic_include_path_id_in_iv in two more files.")

[commit-bot: I haz the power, 2016-03-17 18:06:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811043002/20001

[commit-bot: I haz the power, 2016-03-17 18:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 18:18:24]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[fnk, 2016-03-17 18:42:45]

The CQ bit was checked by fnk@chromium.org

[fnk, 2016-03-17 18:42:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1811043002/#ps40001
(title: "Add a default case to a switch statement.")

[commit-bot: I haz the power, 2016-03-17 18:43:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811043002/40001

[fnk, 2016-03-17 19:38:49]

The CQ bit was checked by fnk@chromium.org

[fnk, 2016-03-17 19:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1811043002/#ps60001
(title: "Add an export clause.")

[commit-bot: I haz the power, 2016-03-17 19:39:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811043002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811043002/60001

[commit-bot: I haz the power, 2016-03-17 20:57:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-17 20:58:26]

Description was changed from

==========
Landing Recent QUIC changes until 2016-03-15 16:26 UTC
Up to and including internal change 117245736

Fix a type casting bug in quic stream sequencer buffer.

Withough this change, a QUIC frame with offset higher than 2^32 might corrupt
StreamSequencerBuffer's missing frame recording logic in a 32-bit machine.

Merge internal change: 117245736
https://codereview.chromium.org/1808013003/

Always use recvmmsg or recvmsg if it's available, and consolidate
ReadAndDispatchPackets and ReadAndDispatchSinglePacket into a single API. Not
flag protected. No functional change.

Note that this does somewhat reduce the test coverage of QuicServerTest, now
requiring that changes to QuicPacketReader::ReadAndDispatchSinglePacket be run
on platforms that don't support recvmmsg.

Merge internal change: 117245279
https://codereview.chromium.org/1810103002/

Log when client nonce is invalid. No functional change. Not flag protected.

Merge internal change: 116987771
https://codereview.chromium.org/1810073002/

Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag
protected. No functional change.

Merge internal change: 116973081
https://codereview.chromium.org/1809123002/

Change QUIC tests that use port 80 to use 443.

Merge internal change: 116970314
https://codereview.chromium.org/1808963003/

Use byte conservation instead of packet conservation in QUIC's Slow Start Large
Recovery experiment. Protected by quic_sslr_byte_conservation.

Merge internal change: 116964633
https://codereview.chromium.org/1814873002/

Remove the unused has_retransmittable_data argument from
QuicSendAlgorithm::TimeUntilSend.  No functional change.  Not flag protected.

Merge internal change: 116904472
https://codereview.chromium.org/1814843002/

Deprecates check_peer_address_change_after_decryption.

Merge internal change: 116887287
https://codereview.chromium.org/1808613003/

Deprecate quic_respect_send_alarm2.

Merge internal change: 116879870
https://codereview.chromium.org/1813513002/

Deprecate --quic_include_path_id_in_iv.

Merge internal change: 116877752
https://codereview.chromium.org/1810743002/

Don't copy the QuicAckFrame into the QuicPacketGenerator.  Protected by
quic_dont_copy_acks.

Merge internal change: 116808648
https://codereview.chromium.org/1807033002/

No longer limit QUIC's max CWND to 200 packets.  Protected by
quic_dont_limit_max_cwnd.

This is a fix for the deprecation of a similar flag in cr/113769379.

Merge internal change: 116794514
https://codereview.chromium.org/1812633002/

Remove QuicFrameList, because it's unused with the new QuicStreamSequencer.

Merge internal change: 116768420
https://codereview.chromium.org/1805323003/

Add a QuicConfig option to ask the client not to attempt migration.

Merge internal change: 116712124
https://codereview.chromium.org/1808513003/

Do not disable TLP by default in QuicConnection tests.

Merge internal change: 116698228
https://codereview.chromium.org/1808863002/

Add a new QUIC connection option, 5RTO, which closes the QUIC connection after 5
consecutive RTOs. Protected by quic_enable_rto_timeout.

Merge internal change: 116687954
https://codereview.chromium.org/1806083002/

Change QuicConnection's ScopedPacketBundler to use SEND_QUEUED_ACK instead of
NO_ACK, to ensure a queued ack is always sent.  Small functional change.  Not
flag protected.

Merge internal change: 116677107
https://codereview.chromium.org/1814483002/

deprecate quic_use_rfc7539

Merge internal change: 116589902
https://codereview.chromium.org/1809703002/

Use cached compressed certs if available to reduce load of compressing certs.
Flag protected by quic_use_cached_compressed_certs.

Merge internal change: 116579250.
https://codereview.chromium.org/1808793002/

R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until 2016-03-15 16:26 UTC
Up to and including internal change 117245736

Fix a type casting bug in quic stream sequencer buffer.

Withough this change, a QUIC frame with offset higher than 2^32 might corrupt
StreamSequencerBuffer's missing frame recording logic in a 32-bit machine.

Merge internal change: 117245736
https://codereview.chromium.org/1808013003/

Always use recvmmsg or recvmsg if it's available, and consolidate
ReadAndDispatchPackets and ReadAndDispatchSinglePacket into a single API. Not
flag protected. No functional change.

Note that this does somewhat reduce the test coverage of QuicServerTest, now
requiring that changes to QuicPacketReader::ReadAndDispatchSinglePacket be run
on platforms that don't support recvmmsg.

Merge internal change: 117245279
https://codereview.chromium.org/1810103002/

Log when client nonce is invalid. No functional change. Not flag protected.

Merge internal change: 116987771
https://codereview.chromium.org/1810073002/

Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag
protected. No functional change.

Merge internal change: 116973081
https://codereview.chromium.org/1809123002/

Change QUIC tests that use port 80 to use 443.

Merge internal change: 116970314
https://codereview.chromium.org/1808963003/

Use byte conservation instead of packet conservation in QUIC's Slow Start Large
Recovery experiment. Protected by quic_sslr_byte_conservation.

Merge internal change: 116964633
https://codereview.chromium.org/1814873002/

Remove the unused has_retransmittable_data argument from
QuicSendAlgorithm::TimeUntilSend.  No functional change.  Not flag protected.

Merge internal change: 116904472
https://codereview.chromium.org/1814843002/

Deprecates check_peer_address_change_after_decryption.

Merge internal change: 116887287
https://codereview.chromium.org/1808613003/

Deprecate quic_respect_send_alarm2.

Merge internal change: 116879870
https://codereview.chromium.org/1813513002/

Deprecate --quic_include_path_id_in_iv.

Merge internal change: 116877752
https://codereview.chromium.org/1810743002/

Don't copy the QuicAckFrame into the QuicPacketGenerator.  Protected by
quic_dont_copy_acks.

Merge internal change: 116808648
https://codereview.chromium.org/1807033002/

No longer limit QUIC's max CWND to 200 packets.  Protected by
quic_dont_limit_max_cwnd.

This is a fix for the deprecation of a similar flag in cr/113769379.

Merge internal change: 116794514
https://codereview.chromium.org/1812633002/

Remove QuicFrameList, because it's unused with the new QuicStreamSequencer.

Merge internal change: 116768420
https://codereview.chromium.org/1805323003/

Add a QuicConfig option to ask the client not to attempt migration.

Merge internal change: 116712124
https://codereview.chromium.org/1808513003/

Do not disable TLP by default in QuicConnection tests.

Merge internal change: 116698228
https://codereview.chromium.org/1808863002/

Add a new QUIC connection option, 5RTO, which closes the QUIC connection after 5
consecutive RTOs. Protected by quic_enable_rto_timeout.

Merge internal change: 116687954
https://codereview.chromium.org/1806083002/

Change QuicConnection's ScopedPacketBundler to use SEND_QUEUED_ACK instead of
NO_ACK, to ensure a queued ack is always sent.  Small functional change.  Not
flag protected.

Merge internal change: 116677107
https://codereview.chromium.org/1814483002/

deprecate quic_use_rfc7539

Merge internal change: 116589902
https://codereview.chromium.org/1809703002/

Use cached compressed certs if available to reduce load of compressing certs.
Flag protected by quic_use_cached_compressed_certs.

Merge internal change: 116579250.
https://codereview.chromium.org/1808793002/

R=rch@chromium.org
BUG=

Committed: https://crrev.com/f57804c4c8609f1c6c396eddb6a3174d2003362c
Cr-Commit-Position: refs/heads/master@{#381795}
==========

[commit-bot: I haz the power, 2016-03-17 20:58:28]

Patchset 4 (id:??) landed as
https://crrev.com/f57804c4c8609f1c6c396eddb6a3174d2003362c
Cr-Commit-Position: refs/heads/master@{#381795}