Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1811033002: [WebView] Fix GN builds that use "use_webview_internal_framework". (Closed)

Created:
4 years, 9 months ago by mikecase (-- gone --)
Modified:
4 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Fix GN builds that use "use_webview_internal_framework". system_webview_apk target only exists when use_webview_internal_framework is false. Removing this additional_apk to fix the build. BUG=595605 TBR=sgurun@chromium.org Committed: https://crrev.com/bcb3c5ce9f2ce6c51250848a4b1dbb462896a1fb Cr-Commit-Position: refs/heads/master@{#381747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M android_webview/tools/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811033002/1
4 years, 9 months ago (2016-03-17 17:30:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 18:11:20 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bcb3c5ce9f2ce6c51250848a4b1dbb462896a1fb Cr-Commit-Position: refs/heads/master@{#381747}
4 years, 9 months ago (2016-03-17 18:13:00 UTC) #7
sgurun-gerrit only
4 years, 9 months ago (2016-03-18 17:42:37 UTC) #8
Message was sent while issue was closed.
On 2016/03/17 18:13:00, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/bcb3c5ce9f2ce6c51250848a4b1dbb462896a1fb
> Cr-Commit-Position: refs/heads/master@{#381747}

lgtm

Powered by Google App Engine
This is Rietveld 408576698