Issue 181103005: Move LiveNodeList code out of HTMLCollection.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181103005: Move LiveNodeList code out of HTMLCollection.cpp (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis, deepak.sa

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move LiveNodeList code out of HTMLCollection.cpp Move LiveNodeList code out of HTMLCollection.cpp and into the LiveNodeList.* files. Code that is shared between LiveNodeList and HTMLCollection was moved to the LiveNodeListBase header. R=adamk, esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167926

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -57 lines)			Patch
M	Source/core/dom/LiveNodeList.cpp	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	Source/core/dom/LiveNodeListBase.h	View	3 chunks	+38 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	2 chunks	+0 lines, -57 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/181103005/1

6 years, 10 months ago (2014-02-26 18:02:25 UTC) #4

Message was sent while issue was closed.

Change committed as 167926

Expand Messages | Collapse Messages