Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: Source/core/editing/ApplyStyleCommand.cpp

Issue 181103004: Fixing crash when executing ApplyStyle command. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix for crash Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/ApplyStyleCommand.cpp
diff --git a/Source/core/editing/ApplyStyleCommand.cpp b/Source/core/editing/ApplyStyleCommand.cpp
index 966eea4a23de22c26d4cc6a017be3c59dd033627..0455946c8e633e6da310715907b14aad0213361a 100644
--- a/Source/core/editing/ApplyStyleCommand.cpp
+++ b/Source/core/editing/ApplyStyleCommand.cpp
@@ -812,13 +812,16 @@ void ApplyStyleCommand::applyInlineStyleToNodeRange(EditingStyle* style, PassRef
for (size_t i = 0; i < runs.size(); i++) {
removeConflictingInlineStyleFromRun(style, runs[i].start, runs[i].end, runs[i].pastEndNode);
- runs[i].positionForStyleComputation = positionToComputeInlineStyleChange(runs[i].start, runs[i].dummyElement);
+ if (runs[i].startAndEndAreStillInDocument())
+ runs[i].positionForStyleComputation = positionToComputeInlineStyleChange(runs[i].start, runs[i].dummyElement);
}
document().updateLayoutIgnorePendingStylesheets();
- for (size_t i = 0; i < runs.size(); i++)
- runs[i].change = StyleChange(style, runs[i].positionForStyleComputation);
+ for (size_t i = 0; i < runs.size(); i++) {
+ if (!runs[i].positionForStyleComputation.isNull())
yosin_UTC9 2014/03/03 02:06:45 nit: We can use |Position::isNotNull()| here.
arpitab_ 2014/03/03 06:00:00 Done.
+ runs[i].change = StyleChange(style, runs[i].positionForStyleComputation);
+ }
for (size_t i = 0; i < runs.size(); i++) {
InlineRunToApplyStyle& run = runs[i];

Powered by Google App Engine
This is Rietveld 408576698