LayoutTests/editing/execCommand/selection-after-insert-list-expected.txt - Issue 181103004: Fixing crash when executing ApplyStyle command.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/selection-after-insert-list-expected.txt

Issue 181103004: Fixing crash when executing ApplyStyle command. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing review comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 This tests verifies that the selection is properly reset after executing the com mand.	1 This tests verifies that the selection is properly reset after executing the com mand.

2 \| <ol>	2 \| <ol>

3 \| <li>	3 \| <li>

4 \| "AB<#selection-anchor>C"	4 \| "AB<#selection-anchor>C"

5 \| <li>	5 \| <li>

6 \| id="second"

7 \| "DEF<#selection-focus>"	6 \| "DEF<#selection-focus>"

	7 \| <ul>

	8 \| "

	9 "
	Yuta Kitamura 2014/02/27 07:48:15 Could you elaborate on this expectation update? I Could you elaborate on this expectation update? I think your argument of "no visual change" of this test is too weak to support this diff, since almost nothing is rendered from the beginning. And certainly the behavior has changed as id attribute is gone and a new ul is created. You probably need to explain either (a) this is not a regression but a progression, or (b) this change is harmless and won't affect real web pages in a bad way. At least I would like to understand how this behavior change happened.
8 \| "	10 \| "

9 "	11 "

OLD	NEW

OLD	NEW
1 This tests verifies that the selection is properly reset after executing the com mand.	1 This tests verifies that the selection is properly reset after executing the com mand.

2 \| <ol>	2 \| <ol>

3 \| <li>	3 \| <li>

4 \| "AB<#selection-anchor>C"	4 \| "AB<#selection-anchor>C"

5 \| <li>	5 \| <li>

6 \| id="second"

7 \| "DEF<#selection-focus>"	6 \| "DEF<#selection-focus>"

	7 \| <ul>

	8 \| "

	9 "
	Yuta Kitamura 2014/02/27 07:48:15 Could you elaborate on this expectation update? I Could you elaborate on this expectation update? I think your argument of "no visual change" of this test is too weak to support this diff, since almost nothing is rendered from the beginning. And certainly the behavior has changed as id attribute is gone and a new ul is created. You probably need to explain either (a) this is not a regression but a progression, or (b) this change is harmless and won't affect real web pages in a bad way. At least I would like to understand how this behavior change happened.
8 \| "	10 \| "

9 "	11 "

OLD	NEW