LayoutTests/editing/execCommand/selection-after-insert-list-2.html - Issue 181103004: Fixing crash when executing ApplyStyle command.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/selection-after-insert-list-2.html

Issue 181103004: Fixing crash when executing ApplyStyle command. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/editing/execCommand/inserting-ordered-list-crash.html ('K') | « LayoutTests/editing/execCommand/inserting-ordered-list-crash-expected.txt ('k') | LayoutTests/editing/execCommand/selection-after-insert-list-2-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script src="../../resources/dump-as-markup.js"></script>	1 <script src="../../resources/dump-as-markup.js"></script>

2 <div id="test" contenteditable>	2 <div id="test" contenteditable>

3 <ul>	3 <p id="startSelection">A</p>

4 <li id="first">ABC</li>	4 <p>B</p>

5 <li id="second">DEF</li>	5 <p id="endSelection">C</p>

6 </ul>	6 <p>This should not be selected.</p>

7 </div>	7 </div>

8 <script>	8 <script>

9 var selection = window.getSelection();	9 var selection = window.getSelection();

10 var range = document.createRange();	10 var range = document.createRange();

11 range.setStart(document.getElementById('first').firstChild, 2);	11 range.setStart(document.getElementById('startSelection'), 0);

12 range.setEnd(document.getElementById('second').firstChild, 3);	12 range.setEnd(document.getElementById('endSelection'), 1);

13 selection.addRange(range);	13 selection.addRange(range);

14 document.execCommand('InsertOrderedList', false, null);	14 document.execCommand('InsertOrderedList', false, true);
	yosin_UTC9 2014/02/27 01:38:40 We don't need to have \|false\| and \|true\|. "InsertO We don't need to have \|false\| and \|true\|. "InsertOrderedList" command doesn't use them. arpitab_ 2014/02/27 06:56:11 Done. Show quoted text On 2014/02/27 01:38:40, Yoshi wrote: > We don't need to have \|false\| and \|true\|. "InsertOrderedList" command doesn't > use them. Done.
15 Markup.description("This tests verifies that the selection is properly reset aft er executing the command.");	15 Markup.description("This tests verifies that the selection is properly reset aft er executing the command.");

16 Markup.dump('test');	16 Markup.dump('test');

17 </script>	17 </script>

OLD	NEW