LayoutTests/editing/execCommand/inserting-ordered-list-crash.html - Issue 181103004: Fixing crash when executing ApplyStyle command.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/inserting-ordered-list-crash.html

Issue 181103004: Fixing crash when executing ApplyStyle command. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <input>

	5 <hr>

	6 >

	7 <script>

	8 if (window.testRunner)

	9 testRunner.dumpAsText();

	10

	11 document.designMode = 'on';

	12 document.execCommand('SelectAll');

	13 document.execCommand('Strikethrough');

	14 document.execCommand('InsertOrderedList', false);
	yosin_UTC9 2014/02/27 01:38:40 nit: We don't need to have \|false\|, default value nit: We don't need to have \|false\|, default value of second parameter of \|execCommand\| is \|undefined\|, which means \|false\| for \|execCommand\|. arpitab_ 2014/02/27 06:56:11 Done. Show quoted text On 2014/02/27 01:38:40, Yoshi wrote: > nit: We don't need to have \|false\|, default value of second parameter of > \|execCommand\| is \|undefined\|, which means \|false\| for \|execCommand\|. Done.
	15 window.getSelection().deleteFromDocument();

	16 document.execCommand('SelectAll');

	17 document.execCommand('Strikethrough');

	18 document.write('The test passes if the page does not crash.');

	19 </script>

	20 </body>

	21 </html>

OLD	NEW