Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1811013002: PPC: InstanceOfStub incorrectly interprets the hole as a prototype. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: InstanceOfStub incorrectly interprets the hole as a prototype. Port 2aa070be4fd2960df98905b254f12ed801ef26cd Original commit message: Repair this to match what the runtime correctly does, by first checking if the function is a constructor before we access the prototype. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/3a903c424b57341c2bb98f69dc0b4225864ea50e Cr-Commit-Position: refs/heads/master@{#34869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-17 17:12:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811013002/1
4 years, 9 months ago (2016-03-17 17:13:43 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 17:47:54 UTC) #5
john.yan
lgtm
4 years, 9 months ago (2016-03-17 18:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811013002/1
4 years, 9 months ago (2016-03-17 18:10:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 18:13:21 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:14:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a903c424b57341c2bb98f69dc0b4225864ea50e
Cr-Commit-Position: refs/heads/master@{#34869}

Powered by Google App Engine
This is Rietveld 408576698