Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1811003002: Enable material design media playback UI on all platforms. (Closed)

Created:
4 years, 9 months ago by liberato (no reviews please)
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@new_media_ui_desktop
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable material design media playback UI on all platforms. This CL switches the default chrome media player UI to be the material design UI. It is enabled as the default in the finch experiment "NewMediaPlaybackUi", so that it can be disabled via finch if needed. This CL also makes some small test changes to make them compatible with the new UI, and rebaselines quite a few layout tests. BUG=487344 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/928d2159e37047c996cb30202a3946c1eb1dd8ef Cr-Commit-Position: refs/heads/master@{#393557}

Patch Set 1 #

Patch Set 2 : fixed tests #

Patch Set 3 : more test fixes. #

Patch Set 4 : don't cause layout immediately in tests. #

Patch Set 5 : rebaseline most #

Patch Set 6 : always show controls to see if it fixes chromevox. #

Patch Set 7 : fixed chromevox. #

Patch Set 8 : rebased #

Patch Set 9 : NeedsRebaseline => Failure #

Patch Set 10 : checked two more tests. #

Patch Set 11 : removed some debug. #

Patch Set 12 : rebased. #

Patch Set 13 : turned off some TestExpectations to see if it fails. #

Patch Set 14 : re-enabled TestExpectations. #

Patch Set 15 : rebased. #

Patch Set 16 : rebased, fixed test results manually canvas...imagesource #

Patch Set 17 : cleanup. #

Messages

Total messages: 14 (8 generated)
liberato (no reviews please)
Hi the material design desktop UI has been on via experiment for a week or ...
4 years, 7 months ago (2016-05-05 20:44:07 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-06 09:48:25 UTC) #7
mlamouri (slow - plz ping)
lgtm Thanks! :)
4 years, 7 months ago (2016-05-06 12:54:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811003002/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811003002/340001
4 years, 7 months ago (2016-05-13 14:34:05 UTC) #10
commit-bot: I haz the power
Committed patchset #17 (id:340001)
4 years, 7 months ago (2016-05-13 17:08:20 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 17:09:45 UTC) #14
Message was sent while issue was closed.
Patchset 17 (id:??) landed as
https://crrev.com/928d2159e37047c996cb30202a3946c1eb1dd8ef
Cr-Commit-Position: refs/heads/master@{#393557}

Powered by Google App Engine
This is Rietveld 408576698