Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp

Issue 18110006: Remove our logic to handle stopping a load inside startProvisionaLoad callbacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
diff --git a/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp b/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
index f1be44409e90d98de5ac750d90918d9048845366..808d099af6f2d9cbe1f06358517cfe877bc46ee4 100644
--- a/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
+++ b/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
@@ -235,7 +235,6 @@ TestRunner::TestRunner(TestInterfaces* interfaces)
bindMethod("setAudioData", &TestRunner::setAudioData);
bindMethod("dumpFrameLoadCallbacks", &TestRunner::dumpFrameLoadCallbacks);
bindMethod("dumpUserGestureInFrameLoadCallbacks", &TestRunner::dumpUserGestureInFrameLoadCallbacks);
- bindMethod("setStopProvisionalFrameLoads", &TestRunner::setStopProvisionalFrameLoads);
bindMethod("dumpTitleChanges", &TestRunner::dumpTitleChanges);
bindMethod("dumpCreateView", &TestRunner::dumpCreateView);
bindMethod("setCanOpenWindows", &TestRunner::setCanOpenWindows);
@@ -391,7 +390,6 @@ void TestRunner::reset()
m_dumpAsAudio = false;
m_dumpFrameLoadCallbacks = false;
m_dumpUserGestureInFrameLoadCallbacks = false;
- m_stopProvisionalFrameLoads = false;
m_dumpTitleChanges = false;
m_dumpCreateView = false;
m_canOpenWindows = false;
@@ -520,11 +518,6 @@ bool TestRunner::shouldDumpUserGestureInFrameLoadCallbacks() const
return m_testIsRunning && m_dumpUserGestureInFrameLoadCallbacks;
}
-bool TestRunner::stopProvisionalFrameLoads() const
-{
- return m_stopProvisionalFrameLoads;
-}
-
bool TestRunner::shouldDumpTitleChanges() const
{
return m_dumpTitleChanges;
@@ -1907,12 +1900,6 @@ void TestRunner::dumpUserGestureInFrameLoadCallbacks(const CppArgumentList&, Cpp
result->setNull();
}
-void TestRunner::setStopProvisionalFrameLoads(const CppArgumentList&, CppVariant* result)
-{
- result->setNull();
- m_stopProvisionalFrameLoads = true;
-}
-
void TestRunner::dumpTitleChanges(const CppArgumentList&, CppVariant* result)
{
m_dumpTitleChanges = true;

Powered by Google App Engine
This is Rietveld 408576698