Issue 18110006: Remove our logic to handle stopping a load inside startProvisionaLoad callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18110006: Remove our logic to handle stopping a load inside startProvisionaLoad callbacks (Closed)

Created:
7 years, 5 months ago by Nate Chapin

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove our logic to handle stopping a load inside startProvisionaLoad callbacks We don't seem to ever use this capacity. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153194

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -71 lines)			Patch
D	LayoutTests/fast/loader/stop-provisional-loads.html	View		1 chunk	+0 lines, -17 lines	0 comments	Download
D	LayoutTests/fast/loader/stop-provisional-loads-expected.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/loader/FrameLoader.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	1	2 chunks	+7 lines, -21 lines	0 comments	Download
M	Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h	View		3 chunks	+0 lines, -9 lines	0 comments	Download
M	Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp	View	1	4 chunks	+0 lines, -13 lines	0 comments	Download
M	Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM! https://codereview.chromium.org/18110006/diff/1/Source/core/loader/FrameLoader.cpp File Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/18110006/diff/1/Source/core/loader/FrameLoader.cpp#newcode2106 Source/core/loader/FrameLoader.cpp:2106: // Notify accessibility. I would remove this comment ...

7 years, 5 months ago (2013-06-27 23:21:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/18110006/5001

7 years, 5 months ago (2013-06-27 23:38:40 UTC) #3

Message was sent while issue was closed.

Change committed as 153194

Expand Messages | Collapse Messages