Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1810993002: Don't improve Bluetooth Adapter name on Linux (Closed)

Created:
4 years, 9 months ago by François Beaufort
Modified:
4 years, 8 months ago
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: only improve Bluetooth Adapter name on Chrome OS BUG=577486 Committed: https://crrev.com/c8901b4dbb6518940e940213c1f94774fc04d5aa Cr-Commit-Position: refs/heads/master@{#384326}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M device/bluetooth/bluetooth_adapter_bluez.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_bluez.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
fbeaufortchromium
Hello Vincent, Could you take a look at this simple patch which basically only override ...
4 years, 8 months ago (2016-03-30 12:51:26 UTC) #2
ortuno
https://codereview.chromium.org/1810993002/diff/1/device/bluetooth/bluetooth_adapter_bluez.cc File device/bluetooth/bluetooth_adapter_bluez.cc (right): https://codereview.chromium.org/1810993002/diff/1/device/bluetooth/bluetooth_adapter_bluez.cc#newcode838 device/bluetooth/bluetooth_adapter_bluez.cc:838: #elif defined(OS_LINUX) You are moving this after "SetName" so ...
4 years, 8 months ago (2016-03-30 17:11:57 UTC) #4
fbeaufortchromium
On 2016/03/30 17:11:57, ortuno wrote: > https://codereview.chromium.org/1810993002/diff/1/device/bluetooth/bluetooth_adapter_bluez.cc > File device/bluetooth/bluetooth_adapter_bluez.cc (right): > > https://codereview.chromium.org/1810993002/diff/1/device/bluetooth/bluetooth_adapter_bluez.cc#newcode838 > ...
4 years, 8 months ago (2016-03-31 11:30:39 UTC) #5
ortuno
lgtm
4 years, 8 months ago (2016-03-31 14:50:57 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810993002/60001
4 years, 8 months ago (2016-03-31 14:51:20 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 16:05:54 UTC) #12
scheib
LGTM
4 years, 8 months ago (2016-03-31 17:47:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810993002/60001
4 years, 8 months ago (2016-03-31 17:47:45 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-03-31 18:00:52 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:03:26 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c8901b4dbb6518940e940213c1f94774fc04d5aa
Cr-Commit-Position: refs/heads/master@{#384326}

Powered by Google App Engine
This is Rietveld 408576698