Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1810953002: InstanceOfStub incorrectly interprets the hole as a prototype. (Closed)

Created:
4 years, 9 months ago by mvstanton
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

InstanceOfStub incorrectly interprets the hole as a prototype. Repair this to match what the runtime correctly does, by first checking if the function is a constructor before we access the prototype. R=verwaest@chromium.org BUG= Committed: https://crrev.com/2aa070be4fd2960df98905b254f12ed801ef26cd Cr-Commit-Position: refs/heads/master@{#34863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-573858.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Toon, Here is a CL for the issue we discussed, thx for the look! ...
4 years, 9 months ago (2016-03-17 13:07:55 UTC) #1
Toon Verwaest
lgtm, awesome :)
4 years, 9 months ago (2016-03-17 14:06:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810953002/1
4 years, 9 months ago (2016-03-17 14:25:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 14:30:46 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 14:32:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2aa070be4fd2960df98905b254f12ed801ef26cd
Cr-Commit-Position: refs/heads/master@{#34863}

Powered by Google App Engine
This is Rietveld 408576698