Chromium Code Reviews| Index: test/cctest/test-parsing.cc |
| diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc |
| index d69ae58da5b3c94b6e99d7277f27c34e83587778..e4a9ece183777c0f0c2511035dc38d132ac9c214 100644 |
| --- a/test/cctest/test-parsing.cc |
| +++ b/test/cctest/test-parsing.cc |
| @@ -7396,6 +7396,9 @@ TEST(TypedModeSimpleTypes) { |
| "var s: (a: number, b?: string, c?) => number", |
| "var s: (a: number, b: string, c, ...d) => number", |
| "var s: (a: number, b: string, c, ...d: string[]) => number", |
| + "var s: (number) => number", |
| + "var s: (number: any) => number", |
| + "var s: (any: number) => number", |
| NULL |
| }; |
| @@ -7501,3 +7504,45 @@ TEST(TypedModeStringLiteralTypes) { |
| RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, |
| always_flags, arraysize(always_flags)); |
| } |
| + |
| +TEST(TypedModeTupleTypes) { |
| + const char* untyped_context_data[][2] = {{"", ""}, {NULL, NULL}}; |
| + const char* typed_context_data[][2] = {{"'use types'; ", ""}, {NULL, NULL}}; |
| + |
| + const char* correct_data[] = { |
| + "var x: [number]", |
| + "var x: [number, string]", |
| + "var x: [number[], (a: string, b?: number) => boolean]", |
| + "var f: ([]: number[]) => boolean", |
| + "var f: ([x]: number[]) => boolean", |
| + "var f: ([x, y]: number[]) => boolean", |
| + "var f: ([x,, y]: number[]) => boolean", |
| + "var f: ([, x,, y,,]: number[]) => boolean", |
| + "var f: ([x, y, ...rest]: number[]) => boolean", |
| + "var f: ([any]) => number", |
| + "var f: ([number]: number[]) => number", |
| + "var f: ([one, two, ...number]: number[]) => boolean", |
| + NULL |
| + }; |
| + |
| + const char* error_data[] = { |
| + "var z: []", |
| + "var z: [()]", |
| + "var z: [number,]", |
| + "var x: [number[], (a: string, b?: number)]", |
|
rossberg
2016/03/17 16:51:37
What about simpler cases like
[number, (a: string
nickie
2016/03/18 11:12:01
I'm adding the first. The second is valid, 'a' be
|
| + "var z: [, number]", |
| + "var z: [string,, number]", |
| + "var z: [string,, ...number]", |
| + NULL |
| + }; |
| + |
| + static const ParserFlag always_flags[] = {kAllowTypes}; |
| + RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| + RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0, |
| + always_flags, arraysize(always_flags)); |
| +} |