Fix error introduced in r167687 and add copy constructor to PersistentHeapVector.

Source/core/html/shadow/TextControlInnerElements.h

 /*
  * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 116 matching lines @@
 private:
     InputFieldSpeechButtonElement(Document&);
     SpeechInput* speechInput();
     void setState(SpeechInputState state);
     virtual bool isMouseFocusable() const OVERRIDE { return false; }
     virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
 
     bool m_capturing;
     SpeechInputState m_state;
     int m_listenerId;
-    SpeechInputResultArray m_results;
+    PersistentSpeechInputResultArray m_results;

[Mads Ager (chromium), 2014/02/26 09:38:41]

WillBePersistentSpeechInputResultArray to make it clear that there is a
transition type involved here?

[haraken, 2014/02/26 09:43:15]

I slightly disagree. We've not used "WillBe" for typedefs. The advantage of not
using "WillBe" in typedefs is we don't need to edit a lot of places when
switching to real types :)

[Mads Ager (chromium), 2014/02/26 09:49:06]

In this particular case, having Persistent in the name might be indication
enough. However, it is not a persistent when compiling without enable_oilpan so
the name is slightly misleading. If we could consistently use
SpeechInputResultArray I agree that we don't need the WillBe prefix. When we
move InputFieldSpeechButtonElement to the heap we can completely remove this new
typedef. It is just temporary naming so I don't feel that strongly about it. :-)

Overall, these typedefs are a little dangerous as this change shows. When using
a transition type in a typedef we really need to find all usages and check that
they are traced with enable_oilpan.

 };
 
 DEFINE_TYPE_CASTS(InputFieldSpeechButtonElement, Element, element, element->isInputFieldSpeechButtonElement(), element.isInputFieldSpeechButtonElement());
 
 #endif // ENABLE(INPUT_SPEECH)
 
 } // namespace
 
 #endif