Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 1810923002: Update FilteringResult UMA to include whitelist information. (Closed)

Created:
4 years, 9 months ago by atanasova
Modified:
4 years, 9 months ago
Reviewers:
Marc Treib, rkaplow
CC:
chromium-reviews, pam+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update FilteringResult UMA to include whitelist information. Add new histogram value for hen a navigation is allowed due to it being part of a whitelist. BUG=595640 Committed: https://crrev.com/6d78ae46074968cc7ab3a44b45fdc93941d0f15e Cr-Commit-Position: refs/heads/master@{#381723}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M chrome/browser/supervised_user/supervised_user_resource_throttle.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
atanasova
4 years, 9 months ago (2016-03-17 10:48:34 UTC) #2
Marc Treib
https://codereview.chromium.org/1810923002/diff/1/chrome/browser/supervised_user/supervised_user_resource_throttle.cc File chrome/browser/supervised_user/supervised_user_resource_throttle.cc (right): https://codereview.chromium.org/1810923002/diff/1/chrome/browser/supervised_user/supervised_user_resource_throttle.cc#newcode57 chrome/browser/supervised_user/supervised_user_resource_throttle.cc:57: return FILTERING_BEHAVIOR_ALLOW_WHITELIST; This should go under the case for ...
4 years, 9 months ago (2016-03-17 10:53:14 UTC) #3
atanasova
https://codereview.chromium.org/1810923002/diff/1/chrome/browser/supervised_user/supervised_user_resource_throttle.cc File chrome/browser/supervised_user/supervised_user_resource_throttle.cc (right): https://codereview.chromium.org/1810923002/diff/1/chrome/browser/supervised_user/supervised_user_resource_throttle.cc#newcode57 chrome/browser/supervised_user/supervised_user_resource_throttle.cc:57: return FILTERING_BEHAVIOR_ALLOW_WHITELIST; On 2016/03/17 10:53:14, Marc Treib wrote: > ...
4 years, 9 months ago (2016-03-17 11:13:21 UTC) #4
Marc Treib
LGTM, thanks!
4 years, 9 months ago (2016-03-17 11:14:49 UTC) #5
atanasova
Adding rkaplow@ for histogram changes approval.
4 years, 9 months ago (2016-03-17 11:17:24 UTC) #7
rkaplow
lgtm
4 years, 9 months ago (2016-03-17 14:42:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810923002/20001
4 years, 9 months ago (2016-03-17 14:43:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 16:07:13 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 16:08:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d78ae46074968cc7ab3a44b45fdc93941d0f15e
Cr-Commit-Position: refs/heads/master@{#381723}

Powered by Google App Engine
This is Rietveld 408576698