Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810893003: Trim some headers from base/memory/scoped_ptr.h (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
danakj, brettw
CC:
cbentzel+watch_chromium.org, cc-bugs_chromium.org, chasej+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, gavinp+memory_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mmenke, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim some headers from base/memory/scoped_ptr.h BUG=554298 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=brettw@chromium.org Committed: https://crrev.com/7a424887acfb34ff97b2e98ea6188f512f609684 Cr-Commit-Position: refs/heads/master@{#381793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M base/memory/scoped_ptr.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/base/contiguous_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/geofencing/geofencing_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/origin_trials/web_trial_token_validator_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/dns/dns_transaction.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gestures/blink/web_gesture_curve_impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
dcheng
No scientific basis for removing these headers first, other than I figured they would be ...
4 years, 9 months ago (2016-03-17 17:37:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810893003/1
4 years, 9 months ago (2016-03-17 17:38:05 UTC) #5
danakj
LGTM
4 years, 9 months ago (2016-03-17 18:52:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810893003/1
4 years, 9 months ago (2016-03-17 19:18:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/158170)
4 years, 9 months ago (2016-03-17 19:29:14 UTC) #11
dcheng
TBRing brettw@ for global approval (just simple changes to add a header)
4 years, 9 months ago (2016-03-17 19:36:56 UTC) #14
dcheng
Really adding brettw to review this time.
4 years, 9 months ago (2016-03-17 19:37:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810893003/1
4 years, 9 months ago (2016-03-17 19:37:34 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 20:53:22 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 20:55:10 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7a424887acfb34ff97b2e98ea6188f512f609684
Cr-Commit-Position: refs/heads/master@{#381793}

Powered by Google App Engine
This is Rietveld 408576698