Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1810833002: Blink Compositor Animations: Add tests for resetting delegate in CC on Blink player deletion. (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 9 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans, ajuma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Compositor Animations: Add tests for resetting delegate in CC on Blink player deletion. cc::AnimationPlayer is an RC object, so it may outsurvive blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline. We must clean-up animation delegate in cc::AnimationPlayer on blink::CompositorAnimationPlayer deletion. This is tests for this CL: https://codereview.chromium.org/1747283004/ BUG=590803 Committed: https://crrev.com/edee7a0be8d8c2d2bcb0ac951586fe8344d7b124 Cr-Commit-Position: refs/heads/master@{#381621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp View 1 chunk +82 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
loyso (OOO)
4 years, 9 months ago (2016-03-17 00:17:11 UTC) #3
alancutter (OOO until 2018)
lgtm
4 years, 9 months ago (2016-03-17 00:47:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810833002/1
4 years, 9 months ago (2016-03-17 00:48:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 01:10:40 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 01:12:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edee7a0be8d8c2d2bcb0ac951586fe8344d7b124
Cr-Commit-Position: refs/heads/master@{#381621}

Powered by Google App Engine
This is Rietveld 408576698