Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810823003: [Autofill] Disable AutofillInteractiveTest.OnSelectOptionFromDatalist on ChromeOS (Flaky). (Closed)

Created:
4 years, 9 months ago by sebsg
Modified:
4 years, 9 months ago
Reviewers:
Mathieu
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Disable AutofillInteractiveTest.OnSelectOptionFromDatalist on ChromeOS (Flaky). BUG=595385

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/autofill/autofill_interactive_uitest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sebsg
PTAL
4 years, 9 months ago (2016-03-17 14:55:21 UTC) #2
Mathieu
lgtm with nit https://codereview.chromium.org/1810823003/diff/1/chrome/browser/autofill/autofill_interactive_uitest.cc File chrome/browser/autofill/autofill_interactive_uitest.cc (right): https://codereview.chromium.org/1810823003/diff/1/chrome/browser/autofill/autofill_interactive_uitest.cc#newcode662 chrome/browser/autofill/autofill_interactive_uitest.cc:662: // And on ChromeOs. nit: could ...
4 years, 9 months ago (2016-03-18 13:48:16 UTC) #3
sebsg
Thanks! https://codereview.chromium.org/1810823003/diff/1/chrome/browser/autofill/autofill_interactive_uitest.cc File chrome/browser/autofill/autofill_interactive_uitest.cc (right): https://codereview.chromium.org/1810823003/diff/1/chrome/browser/autofill/autofill_interactive_uitest.cc#newcode662 chrome/browser/autofill/autofill_interactive_uitest.cc:662: // And on ChromeOs. On 2016/03/18 13:48:16, Mathieu ...
4 years, 9 months ago (2016-03-18 13:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810823003/20001
4 years, 9 months ago (2016-03-18 13:57:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/198632)
4 years, 9 months ago (2016-03-18 15:13:20 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 15:27:22 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698