media/mojo/services/android_mojo_media_client.h - Issue 1810763002: Connect Mojo AudioDecoder service to the Mojo service factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/android_mojo_media_client.h

Issue 1810763002: Connect Mojo AudioDecoder service to the Mojo service factory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@spitzer-audio-service-stub

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/mojo/interfaces/service_factory.mojom ('k') | media/mojo/services/android_mojo_media_client.cc » ('j') | media/mojo/services/mojo_audio_decoder_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/mojo/services/android_mojo_media_client.h

diff --git a/media/mojo/services/android_mojo_media_client.h b/media/mojo/services/android_mojo_media_client.h

index 57ae4330bcc7184d377bb0b7a2b4f69703b9a8e5..c59ad5909901ed6cb6f8f0ba719de38640fe6d44 100644

--- a/media/mojo/services/android_mojo_media_client.h

+++ b/media/mojo/services/android_mojo_media_client.h

@@ -16,6 +16,9 @@ class AndroidMojoMediaClient : public MojoMediaClient {

~AndroidMojoMediaClient() final;

// MojoMediaClient implementation.

+ scoped_ptr<AudioDecoder> CreateAudioDecoder(

+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner) final;

xhwang 2016/03/16 22:09:37 In new recommendation, we don't use const-ref for

Tima Vaisburd 2016/03/17 01:09:02 Done. I modified MediaCodecAudioDecoder as well.

scoped_ptr<CdmFactory> CreateCdmFactory(

mojo::shell::mojom::InterfaceProvider* interface_provider) final;