Connect Mojo AudioDecoder service to the Mojo service factory

Connect Mojo AudioDecoder service to the Mojo service factory

The AudioDecoder service is created by MojiMediaClient directly,
without intermediate factory.

BUG=542910
Committed: https://crrev.com/9a58997bfc4c27c72a0adc6f60b407038973488d
Cr-Commit-Position: refs/heads/master@{#381643}

[Tima Vaisburd, 2016-03-16 21:52:07]

timav@chromium.org changed reviewers:
+ sandersd@chromium.org, xhwang@chromium.org

[Tima Vaisburd, 2016-03-16 21:52:07]

PTAL

[xhwang, 2016-03-16 22:09:37]

lgtm % nit

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/android...
File media/mojo/services/android_mojo_media_client.h (right):

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/android...
media/mojo/services/android_mojo_media_client.h:20: const
scoped_refptr<base::SingleThreadTaskRunner>& task_runner) final;
In new recommendation, we don't use const-ref for scoped_refptr any more. We
should just pass by value in this case:

https://www.chromium.org/developers/coding-style#TOC-Object-ownership-and-cal...

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/mojo_au...
File media/mojo/services/mojo_audio_decoder_service.h (right):

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/mojo_au...
media/mojo/services/mojo_audio_decoder_service.h:19:
scoped_ptr<media::AudioDecoder> decoder,
good catch!

[Tima Vaisburd, 2016-03-17 01:09:03]

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/android...
File media/mojo/services/android_mojo_media_client.h (right):

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/android...
media/mojo/services/android_mojo_media_client.h:20: const
scoped_refptr<base::SingleThreadTaskRunner>& task_runner) final;
On 2016/03/16 22:09:37, xhwang wrote:
> In new recommendation, we don't use const-ref for scoped_refptr any more. We
> should just pass by value in this case:
> 
>
https://www.chromium.org/developers/coding-style#TOC-Object-ownership-and-cal...

Done. I modified MediaCodecAudioDecoder as well.

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/mojo_au...
File media/mojo/services/mojo_audio_decoder_service.h (right):

https://codereview.chromium.org/1810763002/diff/1/media/mojo/services/mojo_au...
media/mojo/services/mojo_audio_decoder_service.h:19:
scoped_ptr<media::AudioDecoder> decoder,
On 2016/03/16 22:09:37, xhwang wrote:
> good catch!

Kudos go to compiler ;)

[Tima Vaisburd, 2016-03-17 01:09:14]

The CQ bit was checked by timav@chromium.org

[Tima Vaisburd, 2016-03-17 01:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1810763002/#ps20001
(title: "Passed scoped_refptr by value instead of const ref")

[commit-bot: I haz the power, 2016-03-17 01:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1810763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1810763002/20001

[commit-bot: I haz the power, 2016-03-17 02:21:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 02:22:40]

Description was changed from

==========
Connect Mojo AudioDecoder service to the Mojo service factory

The AudioDecoder service is created by MojiMediaClient directly,
without intermediate factory.

BUG=542910
==========

to

==========
Connect Mojo AudioDecoder service to the Mojo service factory

The AudioDecoder service is created by MojiMediaClient directly,
without intermediate factory.

BUG=542910

Committed: https://crrev.com/9a58997bfc4c27c72a0adc6f60b407038973488d
Cr-Commit-Position: refs/heads/master@{#381643}
==========

[commit-bot: I haz the power, 2016-03-17 02:22:41]

Patchset 2 (id:??) landed as
https://crrev.com/9a58997bfc4c27c72a0adc6f60b407038973488d
Cr-Commit-Position: refs/heads/master@{#381643}