Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1810693002: Ignore gesture sequences that have no target. (Closed)

Created:
4 years, 9 months ago by wjmaclean
Modified:
4 years, 9 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore gesture sequences that have no target. This CL implements a speculative fix for the associated bug, on the theory that sequences associated with context menus (triggered by GestureLongPress) may not be properly suppressed on Windows, leading to the observation of sequences without any target in RenderWidgetHostInputEventRouter. If this hypothesis is correct, then we should be correct in ignoring such sequences, and this CL implements that. This CL also removes the code for collecting debug data introduced in https://codereview.chromium.org/1783533002/. BUG=592319 Committed: https://crrev.com/2816a742570a0f68237ec9fd6ab31320c36a75e1 Cr-Commit-Position: refs/heads/master@{#381540}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO with bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -49 lines) Patch
M content/browser/renderer_host/render_widget_host_input_event_router.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 6 chunks +4 lines, -33 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810693002/1
4 years, 9 months ago (2016-03-16 18:57:33 UTC) #4
wjmaclean
I'm running this on the bots to sanity check it, but please take a look ...
4 years, 9 months ago (2016-03-16 18:57:35 UTC) #5
tdresser
LGTM % nit. https://codereview.chromium.org/1810693002/diff/1/content/browser/renderer_host/render_widget_host_input_event_router.cc File content/browser/renderer_host/render_widget_host_input_event_router.cc (right): https://codereview.chromium.org/1810693002/diff/1/content/browser/renderer_host/render_widget_host_input_event_router.cc#newcode175 content/browser/renderer_host/render_widget_host_input_event_router.cc:175: // Ignore this gesture sequence as ...
4 years, 9 months ago (2016-03-16 19:23:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810693002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810693002/40001
4 years, 9 months ago (2016-03-16 19:57:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-16 21:00:21 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 21:03:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2816a742570a0f68237ec9fd6ab31320c36a75e1
Cr-Commit-Position: refs/heads/master@{#381540}

Powered by Google App Engine
This is Rietveld 408576698