Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1810663002: Fail gracefully in Script::GetLine under precompilation like Script::GetSnippet. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fail gracefully in Script::GetLine under precompilation like Script::GetSnippet. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/7d3c48acc5c35b2a98a663cc634ba9e7b9660a99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/object.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-16 17:56:05 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-03-16 18:12:41 UTC) #3
rmacnak
4 years, 9 months ago (2016-03-16 19:26:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d3c48acc5c35b2a98a663cc634ba9e7b9660a99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698