Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181063036: Add incognito:split to Chrome Connectivity Diagnostics app (Closed)

Created:
6 years, 9 months ago by Zachary Kuznia
Modified:
6 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add incognito:split to Chrome Connectivity Diagnostics app BUG=346862 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Zachary Kuznia
6 years, 9 months ago (2014-03-05 23:23:26 UTC) #1
xiyuan
lgtm
6 years, 9 months ago (2014-03-05 23:29:55 UTC) #2
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 9 months ago (2014-03-05 23:34:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/181063036/1
6 years, 9 months ago (2014-03-05 23:36:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/181063036/1
6 years, 9 months ago (2014-03-06 00:18:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 02:06:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg Retried try job too often on win_rel for ...
6 years, 9 months ago (2014-03-06 02:06:03 UTC) #7
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 9 months ago (2014-03-06 02:08:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/181063036/1
6 years, 9 months ago (2014-03-06 02:14:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/181063036/1
6 years, 9 months ago (2014-03-06 03:08:21 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 05:39:48 UTC) #11
Message was sent while issue was closed. 
Change committed as 255261

Powered by Google App Engine
This is Rietveld 408576698