Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181063034: [Android] Additional events to observe in TabObserver. (Closed)

Created:
6 years, 9 months ago by aruslan
Modified:
6 years, 9 months ago
Reviewers:
Ted C, aruslan1
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Additional events to observe in TabObserver. BUG=344589, 341231 TEST=none NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255224

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aruslan1
Two new methods, PTAL thanks!
6 years, 9 months ago (2014-03-05 22:28:36 UTC) #1
aruslan1
6 years, 9 months ago (2014-03-06 00:21:49 UTC) #2
Ted C
lgtm https://codereview.chromium.org/181063034/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/181063034/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode152 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:152: // WebContentsDelegateAndroid overrides --------------------------------------------------- why this?
6 years, 9 months ago (2014-03-06 00:27:17 UTC) #3
aruslan1
Thanks! https://codereview.chromium.org/181063034/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/181063034/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode152 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:152: // WebContentsDelegateAndroid overrides --------------------------------------------------- On 2014/03/06 00:27:17, Ted ...
6 years, 9 months ago (2014-03-06 00:31:00 UTC) #4
aruslan1
The CQ bit was checked by aruslan@google.com
6 years, 9 months ago (2014-03-06 00:31:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/181063034/20001
6 years, 9 months ago (2014-03-06 00:34:45 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 02:12:50 UTC) #7
Message was sent while issue was closed. 
Change committed as 255224

Powered by Google App Engine
This is Rietveld 408576698