Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 181063031: Fix AsyncFileTestHelper::ReadDirectory to handle has_more correctly (Closed)

Created:
6 years, 9 months ago by hashimoto
Modified:
6 years, 9 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix AsyncFileTestHelper::ReadDirectory to handle has_more correctly BUG=347900 TEST=content_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255592

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/public/test/async_file_test_helper.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
Jay, could you review this change as an owner of this directory?
6 years, 9 months ago (2014-03-05 12:47:16 UTC) #1
Jay Civelli
This change looks good but I am confused on the actual bug. The bug report ...
6 years, 9 months ago (2014-03-05 18:20:18 UTC) #2
hashimoto
On 2014/03/05 18:20:18, Jay Civelli wrote: > This change looks good but I am confused ...
6 years, 9 months ago (2014-03-06 04:51:12 UTC) #3
Jay Civelli
lgtm
6 years, 9 months ago (2014-03-06 18:07:44 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-07 06:08:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/181063031/1
6 years, 9 months ago (2014-03-07 06:10:51 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 11:59:41 UTC) #7
Message was sent while issue was closed.
Change committed as 255592

Powered by Google App Engine
This is Rietveld 408576698