Fix presubmit checks when --trybot-json flag is specified.

Fix presubmit checks when --trybot-json flag is specified.

Must change current working directory to the presubmit file's directory
to follow the contract of the presubmit scripts.

BUG=348691
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=254618

[alokp, 2014-03-03 20:24:27]

Mike, Pawel: please review this fix. Thanks.

[alokp, 2014-03-03 20:24:55]

Please also note that you need to view the unified diffs. The side-by-side diffs
either aren't uploading or updating properly.

[Paweł Hajdan Jr., 2014-03-03 22:13:39]

Looks like this'd need a chdir back to original in "finally", right?

[Ken Russell (switch to Gerrit), 2014-03-03 22:14:54]

On 2014/03/03 22:13:39, Paweł Hajdan Jr. wrote:
> Looks like this'd need a chdir back to original in "finally", right?

I tried to capture all the fall-through cases but you're right, a finally clause
would be simpler. We'll upload a new patch.

[alokp, 2014-03-03 23:16:30]

Moved the restore to finally. PTAL.

[ghost stip (do not use), 2014-03-04 00:06:54]

this lgtm, but it'd be nice to have a unit test somewhere for this

[Ken Russell (switch to Gerrit), 2014-03-04 00:31:54]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2014-03-04 00:31:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alokp@chromium.org/181063021/60001

[commit-bot: I haz the power, 2014-03-04 00:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-04 00:33:35]

Presubmit check for 181063021-60001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1822 --:--:-- --:--:-- --:--:--  1878
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:8080/5629499534213120
Closing issue (you may be prompted for your codereview password)...
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2470, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2456, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/commit-queue/workdir/tools/depot_tools/subcommand.py", line 245, in
execute
    return command(parser, args[1:])
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1924, in CMDpush
    return SendUpstream(parser, args, 'push')
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1890, in SendUpstream
    cl.RpcServer().add_comment(cl.GetIssue(), comment)
  File "/b/commit-queue/workdir/tools/depot_tools/rietveld.py", line 255, in
add_comment
    ('no_redirect', 'True')])
  File "/b/commit-queue/workdir/tools/depot_tools/rietveld.py", line 385, in
post
    return self._send(request_path, payload=body, content_type=ctype, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/rietveld.py", line 411, in
_send
    result = self.rpc_server.Send(request_path, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
463, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 406, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 444, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 403: Forbidden
FAILURE: git-cl push ok


Presubmit checks took 97.4s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[Ken Russell (switch to Gerrit), 2014-03-04 00:49:56]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2014-03-04 00:50:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alokp@chromium.org/181063021/60001

[commit-bot: I haz the power, 2014-03-04 00:52:19]

Change committed as 254618