Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 181063013: Clean up generated_bindings.gyp (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Clean up generated_bindings.gyp This does some cleanup to GYP; only change to build is consolidating two identical gyp-time files into one. * Move temporary list file variables to the top, with other variables (keeps all these lists together, removes duplicate variables, and removes duplicate comments) * Add comment lines between actions (GYP files are hard to read, and we're going to add more actions for caching lexer/parser) * Fix indentation so consistent (.gyp file formatting isn't terribly consistent or linted, but this makes reading and edits easier) BUG=341748 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168341

Patch Set 1 #

Patch Set 2 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -136 lines) Patch
M Source/bindings/generated_bindings.gyp View 1 7 chunks +138 lines, -136 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Nils Barth (inactive)
Cleanup.
6 years, 9 months ago (2014-03-03 03:57:47 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-03 04:42:42 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-03 06:12:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/181063013/20001
6 years, 9 months ago (2014-03-03 06:12:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 08:53:03 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24329
6 years, 9 months ago (2014-03-03 08:53:04 UTC) #6
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-03 08:57:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/181063013/20001
6 years, 9 months ago (2014-03-03 08:57:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 11:46:40 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24424
6 years, 9 months ago (2014-03-03 11:46:41 UTC) #10
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-03 23:44:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/181063013/20001
6 years, 9 months ago (2014-03-03 23:44:26 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 23:45:01 UTC) #13
Message was sent while issue was closed.
Change committed as 168341

Powered by Google App Engine
This is Rietveld 408576698