Gets the peer address (if available) in server requests.

net/socket/stream_listen_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/stream_listen_socket.h"
 
 #if defined(OS_WIN)
 // winsock2.h must be included first in order to ensure it is included before
 // windows.h.
 #include <winsock2.h>
@@ skipping 82 matching lines @@
 #else
     int err = errno;
 #endif
     return MapSystemError(err);
   }
   if (!address->FromSockAddr(storage.addr, storage.addr_len))
     return ERR_FAILED;
   return OK;
 }
 
+int StreamListenSocket::GetPeerAddress(IPEndPoint* address) {
+  SockaddrStorage storage;
+  if (getpeername(socket_, storage.addr, &storage.addr_len)) {
+    return MapSystemError(errno);

[Ryan Sleevi, 2014/03/11 01:32:43]

|errno| won't be set on Win - it would be WSAGetLastError()

[gunsch, 2014/03/17 16:57:15]

Done.

+  } else if (!address->FromSockAddr(storage.addr, storage.addr_len)) {
+    return ERR_FAILED;

[Ryan Sleevi, 2014/03/11 01:32:43]

ERR_ADDRESS_INVALID

[gunsch, 2014/03/17 16:57:15]

Hm, why ERR_ADDRESS_INVALID? In GetLocalAddress above, ERR_FAILED is used here,
and same in UDBSocketLibEvent::GetPeerAddress.

[Ryan Sleevi, 2014/03/17 19:47:22]

Matches the TCPClientSocket.

I suspect the UDPClientSocket/this class are the ones lagging.

+  } else {
+    return OK;

[Ryan Sleevi, 2014/03/11 01:32:43]

don't use else after return statements

if (getpeername(socket_, storage.addr, &storage.addr_len)))
  return MapSystemError(errno);  // BUGGED as above

if (!address->FromSockAddr(storage.addr, storage.addr_len))
  return ERR_ADDRESS_INVALID;

return OK;

(see other examples of calls to getpeername() in net/

[gunsch, 2014/03/17 16:57:15]

Done.

+  }
+}
+
 SocketDescriptor StreamListenSocket::AcceptSocket() {
   SocketDescriptor conn = HANDLE_EINTR(accept(socket_, NULL, NULL));
   if (conn == kInvalidSocket)
     LOG(ERROR) << "Error accepting connection.";
   else
     SetNonBlocking(conn);
   return conn;
 }
 
 void StreamListenSocket::SendInternal(const char* bytes, int len) {
@@ skipping 185 matching lines @@
 void StreamListenSocket::ResumeReads() {
   DCHECK(reads_paused_);
   reads_paused_ = false;
   if (has_pending_reads_) {
     has_pending_reads_ = false;
     Read();
   }
 }
 
 }  // namespace net