[Extensions] Update extension function/event histogram values

[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)

Committed: https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604
Cr-Commit-Position: refs/heads/master@{#381766}

[Devlin, 2016-03-17 00:32:11]

rdevlin.cronin@chromium.org changed reviewers:
+ mpearson@chromium.org

[Devlin, 2016-03-17 00:32:11]

Mark, mind taking a look?
Antony, FYI.

[Mark P, 2016-03-17 18:31:50]

histograms.xml lgtm

[Devlin, 2016-03-17 19:01:45]

Description was changed from

==========
[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
==========

to

==========
[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)
==========

[Devlin, 2016-03-17 19:01:50]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-17 19:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1810583003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1810583003/1

[commit-bot: I haz the power, 2016-03-17 19:09:41]

Description was changed from

==========
[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)
==========

to

==========
[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)
==========

[commit-bot: I haz the power, 2016-03-17 19:09:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 19:10:33]

Description was changed from

==========
[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)
==========

to

==========
[Extensions] Update extension function/event histogram values

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)

Committed: https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604
Cr-Commit-Position: refs/heads/master@{#381766}
==========

[commit-bot: I haz the power, 2016-03-17 19:10:34]

Patchset 1 (id:??) landed as
https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604
Cr-Commit-Position: refs/heads/master@{#381766}

[Marijn Kruisselbrink, 2016-03-17 21:46:26]

On 2016/03/17 at 19:10:34, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604
> Cr-Commit-Position: refs/heads/master@{#381766}

This breaks the build for me locally:

[1/15] CXX
obj/chrome/browser/extensions/api/gen/chrome/browser/extensions/api/chrome_api_registration.generated_api_registration.o
FAILED: /usr/local/google/home/mek/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/chrome/browser/extensions/api/gen/chrome/browser/extensions/api/chrome_api_registration.generated_api_registration.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64
-DCHROMIUM_BUILD -DCR_CLANG_REVISION=263324-1 -DCOMPONENT_BUILD
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1
-DUSE_CLIPBOARD_AURAX11=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1
-DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS
-DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DFIELDTRIAL_TESTING_ENABLED
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1
-DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL
-DGL_GLEXT_PROTOTYPES -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0
-DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DUSE_LIBPCI=1
-DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen -I../..
-I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/angle
-I../../third_party/WebKit/Source -I../../third_party/WebKit
-Igen/third_party/WebKit -Igen/protoc_out -I../../third_party/protobuf
-I../../third_party/protobuf/src -I../../skia/ext
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -fstack-protector
--param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wall -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Xclang -load -Xclang
/usr/local/google_ssd/mek/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion
-fcolor-diagnostics
-B/usr/local/google_ssd/mek/src/third_party/binutils/Linux_x64/Release/bin
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -pthread
-I/usr/local/google_ssd/mek/src/build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0
-I/usr/local/google_ssd/mek/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
-m64 -march=x86-64
--sysroot=/usr/local/google_ssd/mek/src/build/linux/debian_wheezy_amd64-sysroot
-O0 -g -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11  -c
gen/chrome/browser/extensions/api/generated_api_registration.cc -o
obj/chrome/browser/extensions/api/gen/chrome/browser/extensions/api/chrome_api_registration.generated_api_registration.o
In file included from
gen/chrome/browser/extensions/api/generated_api_registration.cc:32:
../../chrome/browser/extensions/api/preferences_private/preferences_private_api.h:21:7:
error: no member named 'PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE'
in namespace 'extensions::functions'; did you mean
'DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE'?
      PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE
../../extensions/browser/extension_function.h:81:37: note: expanded from macro
'DECLARE_EXTENSION_FUNCTION'
    { return extensions::functions::histogramvalue; }
             ~~~~~~~~~~~~~~~~~~~~~~~^
../../extensions/browser/extension_function_histogram_value.h:720:3: note:
'DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE' declared here
  DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE,
  ^
1 error generated.
ninja: build stopped: subcommand failed.

[Devlin, 2016-03-17 21:52:51]

On 2016/03/17 21:46:26, Marijn Kruisselbrink wrote:
> On 2016/03/17 at 19:10:34, commit-bot wrote:
> > Patchset 1 (id:??) landed as
> https://crrev.com/0f7ccd9b2b45c46f2cc791ce1e23b71bf1772604
> > Cr-Commit-Position: refs/heads/master@{#381766}
> 
> This breaks the build for me locally:
> 
> [1/15] CXX
>
obj/chrome/browser/extensions/api/gen/chrome/browser/extensions/api/chrome_api_registration.generated_api_registration.o
> FAILED: /usr/local/google/home/mek/goma/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
>
obj/chrome/browser/extensions/api/gen/chrome/browser/extensions/api/chrome_api_registration.generated_api_registration.o.d
> -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64
> -DCHROMIUM_BUILD -DCR_CLANG_REVISION=263324-1 -DCOMPONENT_BUILD
> -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
> -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1
> -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1
> -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS
> -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DFIELDTRIAL_TESTING_ENABLED
> -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1
-DENABLE_PLUGINS=1
> -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
> -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
> -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
> -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1
> -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA
-DFULL_SAFE_BROWSING
> -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL
> -DGL_GLEXT_PROTOTYPES -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
> -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0
> -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DUSE_LIBPCI=1
> -DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -D__STDC_CONSTANT_MACROS
> -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
> -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen -I../..
> -I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/angle
> -I../../third_party/WebKit/Source -I../../third_party/WebKit
> -Igen/third_party/WebKit -Igen/protoc_out -I../../third_party/protobuf
> -I../../third_party/protobuf/src -I../../skia/ext
> -I../../third_party/skia/include/core -I../../third_party/skia/include/effects
> -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
> -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
> -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
> -I../../third_party/skia/include/utils -fstack-protector
> --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wall -Wextra
> -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden
-pipe
> -fPIC -Xclang -load -Xclang
>
/usr/local/google_ssd/mek/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
> -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion
> -fcolor-diagnostics
> -B/usr/local/google_ssd/mek/src/third_party/binutils/Linux_x64/Release/bin
> -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
> -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> -Wno-deprecated-register -Wno-inconsistent-missing-override
> -Wno-shift-negative-value -pthread
>
-I/usr/local/google_ssd/mek/src/build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0
>
-I/usr/local/google_ssd/mek/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -m64 -march=x86-64
>
--sysroot=/usr/local/google_ssd/mek/src/build/linux/debian_wheezy_amd64-sysroot
> -O0 -g -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
> -fvisibility-inlines-hidden -std=gnu++11  -c
> gen/chrome/browser/extensions/api/generated_api_registration.cc -o
>
obj/chrome/browser/extensions/api/gen/chrome/browser/extensions/api/chrome_api_registration.generated_api_registration.o
> In file included from
> gen/chrome/browser/extensions/api/generated_api_registration.cc:32:
>
../../chrome/browser/extensions/api/preferences_private/preferences_private_api.h:21:7:
> error: no member named 'PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE'
> in namespace 'extensions::functions'; did you mean
> 'DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE'?
>       PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE)
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE
> ../../extensions/browser/extension_function.h:81:37: note: expanded from macro
> 'DECLARE_EXTENSION_FUNCTION'
>     { return extensions::functions::histogramvalue; }
>              ~~~~~~~~~~~~~~~~~~~~~~~^
> ../../extensions/browser/extension_function_histogram_value.h:720:3: note:
> 'DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE' declared here
>   DELETED_PREFERENCESPRIVATE_GETSYNCCATEGORIESWITHOUTPASSPHRASE,
>   ^
> 1 error generated.
> ninja: build stopped: subcommand failed.

Hmm... c/b/e/api/preferences_private/preferences_private_api.h should have been
removed in crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07.  Do you have that
revision?  (Not sure how you'd have this one without that one...)

[Marijn Kruisselbrink, 2016-03-17 21:55:55]

On 2016/03/17 at 21:52:51, rdevlin.cronin wrote:
> Hmm... c/b/e/api/preferences_private/preferences_private_api.h should have
been removed in crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07.  Do you have
that revision?  (Not sure how you'd have this one without that one...)

Yeah, my mistake. Somehow I ended up with a whole bunch of deleted files still
existing in my checkout. After deleting those (and deleting
gen/chrome/browser/extensions/api/generated_api_registration.cc, apparently that
file isn't auto-regenerated otherwise?) everything is indeed happy. Sorry for
the noise.