Move xfa/include/fxgraphics/fx_graphics.h to xfa/fxgraphics.

xfa/fxgraphics/cfx_pattern.h

+// Copyright 2016 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
+
+#ifndef XFA_FXGRAPHICS_CFX_PATTERN_H_
+#define XFA_FXGRAPHICS_CFX_PATTERN_H_
+
+#include "core/include/fxcrt/fx_coordinates.h"
+#include "core/include/fxcrt/fx_system.h"
+#include "xfa/fxgraphics/include/cfx_graphics.h"
+
+class CFX_DIBitmap;
+class CFX_Matrix;
+
+class CFX_Pattern {
+ public:
+  CFX_Pattern();
+  virtual ~CFX_Pattern();
+
+  FX_ERR Create(FX_HatchStyle hatchStyle,

[Tom Sepez, 2016/03/16 19:38:31]

Does this ever fail?  Do we check the error if it does?  Could this be the ctor
instead?

[dsinclair, 2016/03/16 19:59:16]

Done.

+                const FX_ARGB foreArgb,
+                const FX_ARGB backArgb,
+                CFX_Matrix* matrix = NULL);
+
+ private:
+  friend class CFX_Graphics;
+
+  CFX_Matrix m_matrix;
+  union {

[Tom Sepez, 2016/03/16 19:38:31]

Are some of these cases unused now that the type can't differ?

[dsinclair, 2016/03/16 19:59:16]

Apparently m_rectInfo was never used, and we don't need m_bitmapInfo anymore.
Removed the union and just left the m_hatchInfo struct.

+    struct {
+      CFX_RectF rect;
+      FX_FLOAT xStep;
+      FX_FLOAT yStep;
+      FX_BOOL isColored;
+    } m_rectInfo;
+    struct {
+      CFX_DIBitmap* bitmap;
+      FX_FLOAT x1Step;
+      FX_FLOAT y1Step;
+    } m_bitmapInfo;
+    struct {
+      FX_HatchStyle hatchStyle;
+      FX_ARGB foreArgb;
+      FX_ARGB backArgb;
+    } m_hatchInfo;
+  };
+};
+
+#endif  // XFA_FXGRAPHICS_CFX_PATTERN_H_