Issue 181053005: Push safepoint registers in deferred number-to-i/u only on-demand.

Issue 181053005: Push safepoint registers in deferred number-to-i/u only on-demand. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Push safepoint registers in deferred number-to-i/u only on-demand. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19649

Patch Set 2 : Rename DoDeferredNumberTagI to DoDeferredNumberToIU. #

Total comments: 2

Patch Set 3 : Indentation #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -114 lines)			Patch
M	src/arm/lithium-arm.h	View		1 chunk	+12 lines, -4 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	1 2	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	4 chunks	+41 lines, -34 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	6 chunks	+31 lines, -29 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		1 chunk	+10 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+21 lines, -23 lines	0 comments	Download
M	src/x64/lithium-x64.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with nits. https://codereview.chromium.org/181053005/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/181053005/diff/1/src/arm/lithium-codegen-arm.cc#newcode4651 src/arm/lithium-codegen-arm.cc:4651: void LCodeGen::DoDeferredNumberTagI(LInstruction* instr, Not really part ...

6 years, 9 months ago (2014-02-27 13:52:36 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/181053005/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/181053005/diff/1/src/arm/lithium-codegen-arm.cc#newcode4651 src/arm/lithium-codegen-arm.cc:4651: void LCodeGen::DoDeferredNumberTagI(LInstruction* instr, On 2014/02/27 13:52:36, Sven Panne wrote: ...

6 years, 9 months ago (2014-02-28 06:14:51 UTC) #3

Sven Panne

LGTM (still), this time with an even more important nit... https://codereview.chromium.org/181053005/diff/20001/src/arm/lithium-codegen-arm.h File src/arm/lithium-codegen-arm.h (right): https://codereview.chromium.org/181053005/diff/20001/src/arm/lithium-codegen-arm.h#newcode129 ...

6 years, 9 months ago (2014-02-28 06:59:46 UTC) #4

Benedikt Meurer

https://codereview.chromium.org/181053005/diff/20001/src/arm/lithium-codegen-arm.h File src/arm/lithium-codegen-arm.h (right): https://codereview.chromium.org/181053005/diff/20001/src/arm/lithium-codegen-arm.h#newcode129 src/arm/lithium-codegen-arm.h:129: void DoDeferredNumberTagIU(LInstruction* instr, On 2014/02/28 06:59:46, Sven Panne wrote: ...

6 years, 9 months ago (2014-02-28 07:02:05 UTC) #5

Benedikt Meurer

6 years, 9 months ago (2014-03-04 12:45:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r19649 (presubmit successful).

Expand Messages | Collapse Messages