Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1810483002: Introduce "optimized_out" oddball marker for compilers. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Jarin, Yang, Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce "optimized_out" oddball marker for compilers. This introduces {optimized_out} as another Oddball kind to be used by optimizing compilers when values are being optimized away. The aim is providing visibility when this value leaks into the application domain. Currently this will lead to {undefined} values appearing which then silently propagate through the application. The special oddball can be identified easily as a bug and also the debugger can treat it specially when needed. R=jarin@chromium.org Committed: https://crrev.com/eee34dd50fe06a3e90068d68c14fda1279695ddd Cr-Commit-Position: refs/heads/master@{#34817}

Patch Set 1 #

Patch Set 2 : Fix debugger. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -30 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-graph.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +26 lines, -22 lines 0 comments Download
M src/crankshaft/hydrogen-environment-liveness.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug/debug-frames.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects-debug.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/types.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
Jaro: PTAL. Jakob: FYI. Yang: FYI for potential debugger interaction.
4 years, 9 months ago (2016-03-16 10:18:44 UTC) #2
Jarin
lgtm (once the test expectations are fixed).
4 years, 9 months ago (2016-03-16 10:32:13 UTC) #3
Yang
On 2016/03/16 10:32:13, Jarin wrote: > lgtm (once the test expectations are fixed). Nice!
4 years, 9 months ago (2016-03-16 12:49:29 UTC) #4
Yang
On 2016/03/16 12:49:29, Yang wrote: > On 2016/03/16 10:32:13, Jarin wrote: > > lgtm (once ...
4 years, 9 months ago (2016-03-16 14:23:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810483002/20001
4 years, 9 months ago (2016-03-16 14:23:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 14:30:23 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 14:31:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eee34dd50fe06a3e90068d68c14fda1279695ddd
Cr-Commit-Position: refs/heads/master@{#34817}

Powered by Google App Engine
This is Rietveld 408576698