Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1810433002: [DIAL API] Force increment registry generation on discoverNow. (Closed)

Created:
4 years, 9 months ago by imcheng
Modified:
4 years, 9 months ago
Reviewers:
mark a. foltz
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DIAL API] Force increment registry generation on discoverNow. Change discoverNow to fire the deviceList event with the latest device list even if the list had not changed. The patch ensures that by incrementing the registry generation if discovery was started during discoverNow. BUG=595204 Committed: https://crrev.com/7755e55177abe8fa6f42eaaabffaeeaa167a6161 Cr-Commit-Position: refs/heads/master@{#381823}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/extensions/api/dial/dial_registry.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
imcheng
This can be something that we merge back to M50, but not required since no ...
4 years, 9 months ago (2016-03-17 17:34:19 UTC) #2
imcheng
Actually I have been informed that this will still be an issue for our client ...
4 years, 9 months ago (2016-03-17 17:46:36 UTC) #4
mark a. foltz
lgtm Please add a unit test for this (can be done in a separate patch ...
4 years, 9 months ago (2016-03-17 21:56:30 UTC) #5
imcheng
Yep, will be adding test separately.
4 years, 9 months ago (2016-03-17 21:59:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810433002/20001
4 years, 9 months ago (2016-03-17 22:05:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 22:59:28 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 23:01:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7755e55177abe8fa6f42eaaabffaeeaa167a6161
Cr-Commit-Position: refs/heads/master@{#381823}

Powered by Google App Engine
This is Rietveld 408576698