Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 181043018: Add git thaw/freeze to depot_tools. (Closed)

Created:
6 years, 9 months ago by iannucci
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@git_map
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : comments #

Patch Set 4 : comments #

Patch Set 5 : can pass --help now #

Patch Set 6 : ready to rock #

Total comments: 2

Patch Set 7 : fix space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -10 lines) Patch
A + git-freeze View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
A git-thaw View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M git_common.py View 1 2 3 4 5 5 chunks +27 lines, -7 lines 0 comments Download
A git_freezer.py View 1 2 3 4 5 6 1 chunk +73 lines, -0 lines 0 comments Download
M tests/git_common_test.py View 1 2 3 4 5 2 chunks +12 lines, -1 line 0 comments Download
A tests/git_freezer_test.py View 1 2 3 4 5 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
iannucci
6 years, 9 months ago (2014-02-28 03:26:22 UTC) #1
agable
https://codereview.chromium.org/181043018/diff/20001/git_freezer.py File git_freezer.py (right): https://codereview.chromium.org/181043018/diff/20001/git_freezer.py#newcode19 git_freezer.py:19: """freeze a branches changes.""" possessive https://codereview.chromium.org/181043018/diff/20001/git_freezer.py#newcode25 git_freezer.py:25: run('commit', '-m', ...
6 years, 9 months ago (2014-02-28 19:35:35 UTC) #2
agable
plz respond to inline comments, then lgtm.
6 years, 9 months ago (2014-03-07 21:44:14 UTC) #3
iannucci
TALP, now has tests. simplified freeze logic (no extra status command, fixes a bug)
6 years, 9 months ago (2014-03-12 05:15:50 UTC) #4
agable
lgtm https://codereview.chromium.org/181043018/diff/80001/git_freezer.py File git_freezer.py (right): https://codereview.chromium.org/181043018/diff/80001/git_freezer.py#newcode53 git_freezer.py:53: def CMDfreeze(parser, args): # pragma: no cover two ...
6 years, 9 months ago (2014-03-13 00:45:34 UTC) #5
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 9 months ago (2014-03-13 07:52:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/181043018/100001
6 years, 9 months ago (2014-03-13 07:53:04 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 07:55:18 UTC) #8
Message was sent while issue was closed.
Change committed as 256778

Powered by Google App Engine
This is Rietveld 408576698