extensions/common/url_pattern.cc - Issue 181043006: Implement correct logic for URLPatternSet set operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/url_pattern.cc

Issue 181043006: Implement correct logic for URLPatternSet set operators. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review feedback. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/url_pattern.cc

diff --git a/extensions/common/url_pattern.cc b/extensions/common/url_pattern.cc

index 477d3ddf080f65ea762dad056e27b11622d213cc..3b90f1029d3b03d0e612744656d7077221447047 100644

--- a/extensions/common/url_pattern.cc

+++ b/extensions/common/url_pattern.cc

@@ -461,6 +461,8 @@ bool URLPattern::OverlapsWith(const URLPattern& other) const {

}

bool URLPattern::Contains(const URLPattern& other) const {

+ if (*this == other)

+ return true;

if (match_all_urls())

return true;

return MatchesAllSchemes(other.GetExplicitSchemes())

« no previous file with comments | « no previous file | extensions/common/url_pattern_set.h » ('j') | no next file with comments »