Mixed content iframe checks should use top

Mixed content iframe checks should use top

Prior to this CL, we were using the parent frame when checking iframes for
mixed content. Unfortunately, that breaks the iTunes download page because it
uses an HTTPS iframe to kick off the HTTP download.

This CL causes us to use the top-level frame for this check. That's reasonable
because if the top-level frame is HTTP, the user doesn't have any expectation
that they're being protected from network attackers

This change effectively reverts https://src.chromium.org/viewvc/blink?revision=150260&view=revision.  I tried partially reverting that revision by keeping the blocking behavior, but that broke a number of assumptions in Chromium about how didRunInsecureContent works.  It also broke the ReferrerPolicyTest browser tests in worrying ways.  I would like to get back to blocking mixed content iframes, but we'll need to do that without breaking the iTunes download page.

R=tsepez@chromium.org
BUG=244210
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153937

[Tom Sepez, 2013-07-09 22:21:00]

LGTM, and I think the policy is OK.

[abarth-chromium, 2013-07-09 22:24:14]

On 2013/07/09 22:21:00, Tom Sepez wrote:
> LGTM, and I think the policy is OK.

Thanks!

[commit-bot: I haz the power, 2013-07-09 22:24:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/18104009/1

[commit-bot: I haz the power, 2013-07-10 00:57:08]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-07-10 01:24:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/18104009/1

[commit-bot: I haz the power, 2013-07-10 02:44:59]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-07-10 03:56:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/18104009/1

[commit-bot: I haz the power, 2013-07-10 04:57:40]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-10 05:57:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/18104009/1

[commit-bot: I haz the power, 2013-07-10 06:47:21]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-10 07:34:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/18104009/1

[commit-bot: I haz the power, 2013-07-10 08:01:35]

Failed to trigger a try job on linux_layout_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-07-10 08:02:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/18104009/53002

[commit-bot: I haz the power, 2013-07-10 10:19:53]

Change committed as 153879

[abarth-chromium, 2013-07-10 18:25:00]

This CL was reverted because it broke a bunch of Chromium-side code.  There's
some discussion with details in https://codereview.chromium.org/19002002/.  I'm
going to turn this CL into more of a revert of Tom's earlier CL (meaning
dropping back down to "display" / not blocking).

I would like to move back to blocking, but we need to sort out the compatibility
issues.

[abarth-chromium, 2013-07-10 18:31:56]

@tsepez: Would you like to review this CL again?

[Tom Sepez, 2013-07-10 20:15:53]

On 2013/07/10 18:31:56, abarth wrote:
> @tsepez: Would you like to review this CL again?

LGTM, sadly. Can you ping cevans@ that his CL is reverted and re-open bug?

[commit-bot: I haz the power, 2013-07-10 20:16:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/18104009/59002

[commit-bot: I haz the power, 2013-07-10 23:08:57]

Change committed as 153937