Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 1810393002: Fix unguarded cast to an impl class (issue 26035) (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-18 16:03:18 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-18 16:05:16 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-18 16:07:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0a3c4e847281fb619e6b4358f443e636edc40c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698