Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1810363002: Fix display of wheel event listeners on a page. (Closed)

Created:
4 years, 9 months ago by dtapuska
Modified:
4 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix display of wheel event listeners on a page. Fields were getting duplicated for scrollbars. Mark the entire inner viewport as blocked on scroll if we have a wheel listener we don't need to iterate the tree. BUG=595591 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8f35ce554d594f2069d7f4515602e3fb6a5fc5a9 Cr-Commit-Position: refs/heads/master@{#382053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M cc/debug/debug_rect_history.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/debug_rect_history.cc View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dtapuska
4 years, 9 months ago (2016-03-18 16:49:04 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 9 months ago (2016-03-18 18:48:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810363002/1
4 years, 9 months ago (2016-03-18 18:49:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 19:36:45 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f35ce554d594f2069d7f4515602e3fb6a5fc5a9 Cr-Commit-Position: refs/heads/master@{#382053}
4 years, 9 months ago (2016-03-18 19:39:13 UTC) #11
leviw_travelin_and_unemployed
4 years, 9 months ago (2016-03-18 23:19:49 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1816723003/ by leviw@chromium.org.

The reason for reverting is: Failing on continuous builders.

https://chromegw.corp.google.com/i/official.desktop.continuous/builders/win%2...

BUG=596215.

Powered by Google App Engine
This is Rietveld 408576698