Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1810333004: Replace proprietary codec based test media with open codec based versions. (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
CC:
whywhat, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace proprietary codec based test media with open codec based versions. Removes all aac, h264, mp3, and mp4 based media in favor of vorbis+vp8 so that tests can be run on all classes of Android devices with and without proprietary codecs available. BUG=595499 TEST=reran tests. Committed: https://crrev.com/63d8ad0f3b887a94a3861d9ff38d715ff4f47561 Cr-Commit-Position: refs/heads/master@{#382691}

Patch Set 1 #

Patch Set 2 : Disable test per zqzhang. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -40 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/test/data/android/media/audio.ogg View Binary file 0 comments Download
A + chrome/test/data/android/media/audio-play.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/android/media/mp3-play.html View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/test/data/android/media/mpthreetest.mp3 View Binary file 0 comments Download
M chrome/test/data/android/media/simple_video.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/media/simple_video2.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/android/media/test.mp4 View Binary file 0 comments Download
M chrome/test/data/android/media/test.webm View Binary file 0 comments Download
D chrome/test/data/android/media/test2.mp4 View Binary file 0 comments Download
A chrome/test/data/android/media/test2.webm View Binary file 0 comments Download
M chrome/test/data/android/media/two_videos.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/android/media/video-fullscreen.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/media/video-play.html View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
D content/test/data/android/media/audio-1second.mp3 View Binary file 0 comments Download
D content/test/data/android/media/audio-2seconds.mp3 View Binary file 0 comments Download
D content/test/data/android/media/audio-6seconds.mp3 View Binary file 0 comments Download
M content/test/data/android/media/media-session.html View 1 chunk +4 lines, -7 lines 0 comments Download
D content/test/data/android/media/video-1second.mp4 View Binary file 0 comments Download
A content/test/data/android/media/video-1second.webm View Binary file 0 comments Download
D content/test/data/android/media/video-2seconds.mp4 View Binary file 0 comments Download
A content/test/data/android/media/video-2seconds.webm View Binary file 0 comments Download
D content/test/data/android/media/video-6seconds.mp4 View Binary file 0 comments Download
A content/test/data/android/media/video-6seconds.webm View Binary file 0 comments Download
D content/test/data/android/media/video-6seconds-silent.mp4 View Binary file 0 comments Download
A content/test/data/android/media/video-6seconds-silent.webm View Binary file 0 comments Download

Messages

Total messages: 25 (10 generated)
DaleCurtis
4 years, 9 months ago (2016-03-18 22:08:24 UTC) #2
gone
lgtm
4 years, 9 months ago (2016-03-18 22:10:12 UTC) #3
mlamouri (slow - plz ping)
\o/ drive-by lgtm
4 years, 9 months ago (2016-03-19 15:33:31 UTC) #5
DaleCurtis
Friendly ping abarent@
4 years, 9 months ago (2016-03-21 20:28:13 UTC) #6
aberent
lgtm
4 years, 9 months ago (2016-03-22 09:51:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810333004/1
4 years, 9 months ago (2016-03-22 17:19:22 UTC) #9
Zhiqiang Zhang (Slow)
It seems MediaSessionTest#testShortAudioStopsIfLostFocus starts to fail. Maybe it's flaky. Feel free to disable it and ...
4 years, 9 months ago (2016-03-22 19:32:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/41892)
4 years, 9 months ago (2016-03-22 19:43:30 UTC) #13
DaleCurtis
zqzhang: PTAL to make sure I've disabled the test correctly. Away from my desk so ...
4 years, 9 months ago (2016-03-22 20:21:58 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810333004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810333004/20001
4 years, 9 months ago (2016-03-22 20:22:38 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 21:36:13 UTC) #18
Zhiqiang Zhang (Slow)
lgtm
4 years, 9 months ago (2016-03-22 21:37:45 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810333004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810333004/20001
4 years, 9 months ago (2016-03-22 21:39:44 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 21:49:57 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 21:51:05 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63d8ad0f3b887a94a3861d9ff38d715ff4f47561
Cr-Commit-Position: refs/heads/master@{#382691}

Powered by Google App Engine
This is Rietveld 408576698