Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: src/compiler/pipeline.cc

Issue 1810333003: [turbofan] Move frame elision logic to the end (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index 50846d6e81f6c03c69fa4e2b40c33f8e0b93a96e..415fd5be3d55255c2eeb9143c2aae9cc22418cf1 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -1002,8 +1002,9 @@ struct OptimizeMovesPhase {
struct FrameElisionPhase {
static const char* phase_name() { return "frame elision"; }
- void Run(PipelineData* data, Zone* temp_zone) {
- FrameElider(data->sequence()).Run();
+ void Run(PipelineData* data, Zone* temp_zone,
+ const CallDescriptor* descriptor) {
+ FrameElider(data->sequence()).Run(descriptor);
}
};
@@ -1484,12 +1485,6 @@ void Pipeline::AllocateRegisters(const RegisterConfiguration* config,
Run<MergeSplintersPhase>();
}
- // We plan to enable frame elision only for stubs and bytecode handlers.
- if (FLAG_turbo_frame_elision && info()->IsStub()) {
- Run<LocateSpillSlotsPhase>();
- Run<FrameElisionPhase>();
- }
-
Run<AssignSpillSlotsPhase>();
Run<CommitAssignmentPhase>();
@@ -1500,6 +1495,9 @@ void Pipeline::AllocateRegisters(const RegisterConfiguration* config,
Run<OptimizeMovesPhase>();
}
+ Run<LocateSpillSlotsPhase>();
+ Run<FrameElisionPhase>(descriptor);
+
if (FLAG_trace_turbo_graph) {
OFStream os(stdout);
PrintableInstructionSequence printable = {config, data->sequence()};

Powered by Google App Engine
This is Rietveld 408576698