Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1810333002: exit computeFilters if filter width is zero (Closed)

Created:
4 years, 9 months ago by caryclark
Modified:
4 years, 9 months ago
Reviewers:
_cary, f(malita)
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

exit computeFilters if filter width is zero The fuzzer associated with this bug triggered an assert when building the resize filter. I can't tell if there is a more fundemental bug here or not. Checking for a zero-sized filter fixes the fuzzer. R=fmalita@chromium.org BUG=595856 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810333002 Committed: https://skia.googlesource.com/skia/+/fa4c20e728c2b25f7b1a7d858adc8156005ec229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/core/SkBitmapScaler.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
_cary
4 years, 9 months ago (2016-03-18 14:01:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810333002/1
4 years, 9 months ago (2016-03-18 14:02:13 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-18 14:02:15 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 9 months ago (2016-03-18 20:02:12 UTC) #8
caryclark
4 years, 9 months ago (2016-03-21 16:47:40 UTC) #9
f(malita)
lgtm
4 years, 9 months ago (2016-03-21 18:13:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810333002/1
4 years, 9 months ago (2016-03-21 18:14:12 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:25:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fa4c20e728c2b25f7b1a7d858adc8156005ec229

Powered by Google App Engine
This is Rietveld 408576698