Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 18103005: Create jsondiff tool to capture diffs between two JSON expectations files. (Closed)

Created:
7 years, 5 months ago by epoger
Modified:
7 years, 5 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com, senorblanco, bsalomon, robertphillips, borenet
Visibility:
Public.

Description

Create jsondiff tool to capture diffs between two JSON expectations files. This will be used to view diffs before committing rebaselines, or to review exactly what changed between two baseline revisions in the past. Part of Step 3 in https://goto.google.com/ChecksumTransitionDetail R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=9878

Patch Set 1 #

Patch Set 2 : fix_self_test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -1 line) Patch
M gm/gm_json.py View 1 chunk +6 lines, -0 lines 0 comments Download
A tools/jsondiff.py View 1 chunk +175 lines, -0 lines 1 comment Download
A tools/tests/jsondiff/input/new.json View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/tests/jsondiff/input/old.json View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/tests/jsondiff/output/old-vs-new/output-expected/command_line View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/tests/jsondiff/output/old-vs-new/output-expected/return_value View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/tests/jsondiff/output/old-vs-new/output-expected/stdout View 1 1 chunk +14 lines, -0 lines 0 comments Download
M tools/tests/rebaseline.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/tests/run.sh View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 2.
7 years, 5 months ago (2013-07-02 18:12:04 UTC) #1
epoger
[CCing others who might be interested in knowing what's cooking in rebaseline-land]
7 years, 5 months ago (2013-07-02 18:13:15 UTC) #2
epoger
https://codereview.chromium.org/18103005/diff/2001/tools/jsondiff.py File tools/jsondiff.py (right): https://codereview.chromium.org/18103005/diff/2001/tools/jsondiff.py#newcode13 tools/jsondiff.py:13: and generates an old-vs-new diff dictionary. For now, this ...
7 years, 5 months ago (2013-07-02 18:24:32 UTC) #3
scroggo
lgtm
7 years, 5 months ago (2013-07-02 18:45:38 UTC) #4
epoger
7 years, 5 months ago (2013-07-02 20:22:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r9878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698