third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h - Issue 1810283003: [DevTools] Move getCollectionEntries to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 1810283003: [DevTools] Move getCollectionEntries to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-get-function-details

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

index 35ca8bd9300eed411fd53cb55fff5cca358ea230..832318a743cafb8f74481a0233d36acbeba9ea1b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

@@ -53,7 +53,6 @@ class InjectedScript final {

public:

~InjectedScript();

- void getCollectionEntries(ErrorString*, const String16& objectId, OwnPtr<protocol::Array<protocol::Debugger::CollectionEntry>>* result);

void getProperties(ErrorString*, const String16& objectId, bool ownProperties, bool accessorPropertiesOnly, bool generatePreview, OwnPtr<protocol::Array<protocol::Runtime::PropertyDescriptor>>* result, Maybe<protocol::Runtime::ExceptionDetails>*);

void releaseObject(const String16& objectId);

@@ -61,6 +60,8 @@ public:

PassOwnPtr<protocol::Runtime::RemoteObject> wrapObject(ErrorString*, v8::Local<v8::Value>, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;

bool wrapObjectProperty(ErrorString*, v8::Local<v8::Object>, v8::Local<v8::Value> key, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;

+ bool wrapObjectsInArray(ErrorString*, v8::Local<v8::Array>, v8::Local<v8::Value> property, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;

dgozman 2016/03/21 17:21:02 v8::Local<v8::String> property

dgozman 2016/03/21 17:21:02 wrapPropertyInArray ?

kozy 2016/03/21 19:45:01 Done.

PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Value> table, v8::Local<v8::Value> columns) const;

bool findObject(ErrorString*, const RemoteObjectId&, v8::Local<v8::Value>*) const;

String16 objectGroupName(const RemoteObjectId&) const;