[DevTools] Move getCollectionEntries to native

third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 283 matching lines @@
      * @return {!RuntimeAgent.RemoteObject}
      */
     wrapObject: function(object, groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview)
     {
         if (canAccessInspectedGlobalObject)
             return this._wrapObject(object, groupName, forceValueType, generatePreview);
         return this._fallbackWrapper(object);
     },
 
     /**
+     * @param {!Array<!Object>} array
+     * @param {string} property
+     * @param {string} groupName
+     * @param {boolean} canAccessInspectedGlobalObject
+     * @param {boolean} forceValueType
+     * @param {boolean} generatePreview
+     */
+    wrapObjectsInArray: function(array, property, groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview)
+    {
+        for (var i = 0; i < array.length; ++i) {
+            if (property in array[i])

[dgozman, 2016/03/21 17:21:02]

typeof array[i] === "object"

[kozy, 2016/03/21 19:45:01]

Done.

+                array[i][property] = this.wrapObject(array[i][property], groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview);
+        }
+    },
+
+    /**
      * @param {*} object
      * @return {!RuntimeAgent.RemoteObject}
      */
     _fallbackWrapper: function(object)
     {
         var result = { __proto__: null };
         result.type = typeof object;
         if (this.isPrimitiveValue(object))
             result.value = object;
         else
@@ skipping 129 matching lines @@
             if (!("enumerable" in descriptor))
                 descriptor.enumerable = false;
             if ("symbol" in descriptor)
                 descriptor.symbol = this._wrapObject(descriptor.symbol, objectGroupName);
             push(descriptors, descriptor);
         }
         return descriptors;
     },
 
     /**
-     * @param {string} objectId
-     * @return {!Array.<!Object>|string}
-     */
-    getCollectionEntries: function(objectId)
-    {
-        var parsedObjectId = this._parseObjectId(objectId);
-        var object = this._objectForId(parsedObjectId);
-        if (!object || typeof object !== "object")
-            return "Could not find object with given id";
-        var entries = InjectedScriptHost.collectionEntries(object);
-        if (!entries)
-            return "Object with given id is not a collection";
-        var objectGroupName = InjectedScriptHost.idToObjectGroupName(parsedObjectId.id);
-        for (var i = 0; i < entries.length; ++i) {
-            var entry = nullifyObjectProto(entries[i]);
-            if ("key" in entry)
-                entry.key = this._wrapObject(entry.key, objectGroupName);
-            entry.value = this._wrapObject(entry.value, objectGroupName);
-            entries[i] = entry;
-        }
-        return entries;
-    },
-
-    /**
      * @param {!Object} object
      * @param {boolean=} ownProperties
      * @param {boolean=} accessorPropertiesOnly
      * @param {?Array.<string>=} propertyNamesOnly
      */
     _propertyDescriptors: function*(object, ownProperties, accessorPropertiesOnly, propertyNamesOnly)
     {
         var propertyProcessed = { __proto__: null };
 
         /**
@@ skipping 1086 matching lines @@
      */
     _logEvent: function(event)
     {
         inspectedGlobalObject.console.log(event.type, event);
     }
 }
 
 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl();
 return injectedScript;
 })