Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1810273003: Remove Chrome dependency to empty videosourceinterface.h (Closed)

Created:
4 years, 9 months ago by perkj_chrome
Modified:
4 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Chrome dependency to empty videosourceinterface.h third_party/webrtc/api/videosourceinterface.h has been merged with mediastreaminterface.h and will be removed. BUG=webrtc:5426 Committed: https://crrev.com/913f3c885a3e6803ffbce24da03ba2d2fa1272d9 Cr-Commit-Position: refs/heads/master@{#381998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/renderer/media/webrtc/media_stream_video_webrtc_sink.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/cast_extension_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_connection_to_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_video_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
perkj_chrome
Please?
4 years, 9 months ago (2016-03-18 10:09:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810273003/1
4 years, 9 months ago (2016-03-18 10:10:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 12:27:28 UTC) #6
Sergey Ulanov
lgtm
4 years, 9 months ago (2016-03-18 16:53:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810273003/1
4 years, 9 months ago (2016-03-18 17:13:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 17:19:17 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 17:20:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/913f3c885a3e6803ffbce24da03ba2d2fa1272d9
Cr-Commit-Position: refs/heads/master@{#381998}

Powered by Google App Engine
This is Rietveld 408576698