Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: blimp/client/feature/settings_feature.cc

Issue 1810213009: blimp: Add settings to allow the client to download the whole page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@record_full_document
Patch Set: Minor comment fixes. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "blimp/client/feature/settings_feature.h"
6
7 #include "blimp/common/create_blimp_message.h"
8 #include "blimp/common/proto/blimp_message.pb.h"
9 #include "blimp/common/proto/settings.pb.h"
10 #include "net/base/net_errors.h"
11
12 namespace blimp {
13 namespace client {
14
15 SettingsFeature::SettingsFeature() : record_whole_document_(false) {}
16
17 SettingsFeature::~SettingsFeature() {}
18
19 void SettingsFeature::set_outgoing_message_processor(
20 scoped_ptr<BlimpMessageProcessor> processor) {
21 outgoing_message_processor_ = std::move(processor);
22 }
23
24 void SettingsFeature::SetRecordWholeDocument(bool record_whole_document) {
25 if (record_whole_document_ == record_whole_document)
26 return;
27
28 record_whole_document_ = record_whole_document;
29
30 EngineSettingsMessage* engine_settings;
31 scoped_ptr<BlimpMessage> message = CreateBlimpMessage(&engine_settings);
32 engine_settings->set_record_whole_document(record_whole_document_);
33 outgoing_message_processor_->ProcessMessage(std::move(message),
34 net::CompletionCallback());
35 }
36
37 void SettingsFeature::ProcessMessage(scoped_ptr<BlimpMessage> message,
38 const net::CompletionCallback& callback) {
39 // We don't receive any messages from the engine yet.
40 NOTREACHED() << "Invalid settings message received from the engine.";
41 callback.Run(net::OK);
haibinlu 2016/03/22 17:28:39 remove callback.Run(net::OK);
Khushal 2016/03/25 23:00:22 Are we sure we want to do this? In case of an erro
42 }
43
44 } // namespace client
45 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698