blimp: Add settings to allow the client to download the whole page.

blimp/common/proto/settings.proto

+// Copyright 2015 The Chromium Authors. All rights reserved.

[haibinlu, 2016/03/21 18:25:22]

2016

[Khushal, 2016/03/22 04:11:42]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+
+package blimp;
+
+// This includes any settings/flags that can be set on the client or the engine.
+message SettingsMessage {
+  optional EngineSettingsMessage engine_settings = 1;
+  optional ClientSettingsMessage client_settings = 2;
+}
+
+// Client ==> Engine Settings
+message EngineSettingsMessage {
+
+  // -----------------------Web Preferences----------------------
+  optional bool record_whole_document = 1;
+}
+
+message ClientSettingsMessage {

[haibinlu, 2016/03/21 18:25:22]

what global settings will Engine send to Client? 

remove client/engine settings message, and have a one settings message here,
which list all settings fields?

[Khushal, 2016/03/22 04:11:42]

We don't have any settings that need to be sent to the client right now, but if
we do later, this feature would be the place to add them. I have removed the
client settings message, but would it be better to have the Settings message
include a distinct message type for whether the settings are intended for the
engine?

+// Placeholder for Engine ==> Client settings.
+}