fixed issue 349227: Uninit error due to DuplicateHandle failure - add check on DuplicateHandle and …

content/public/test/mock_render_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/mock_render_process_host.h"
 
 #include "base/lazy_instance.h"
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "content/browser/child_process_security_policy_impl.h"
@@ skipping 125 matching lines @@
 
 bool MockRenderProcessHost::Send(IPC::Message* msg) {
   // Save the message in the sink.
   sink_.OnMessageReceived(*msg);
   delete msg;
   return true;
 }
 
 TransportDIB* MockRenderProcessHost::MapTransportDIB(TransportDIB::Id dib_id) {
 #if defined(OS_WIN)
   HANDLE duped;

[sky, 2014/03/05 17:36:50]

Can you instead explicitly set to duped to NULL here?

[zhaoqin, 2014/03/05 19:09:42]

I think it is better to set on failure instead of here.
Because the DuplicateHandle may set duped to be any value (e.g.,
INVALID_HANDLE_VALUE) if the call failed and the value may change cross windows
versions, since the behavior is not documented.
Setting duped to be NULL on failure will handle such cases, so it is safer.

-  DuplicateHandle(GetCurrentProcess(), dib_id.handle, GetCurrentProcess(),
-                  &duped, 0, TRUE, DUPLICATE_SAME_ACCESS);
+  if (!DuplicateHandle(GetCurrentProcess(), dib_id.handle, GetCurrentProcess(),
+                       &duped, 0, TRUE, DUPLICATE_SAME_ACCESS))
+    duped = NULL;

[Will Harris, 2014/03/05 17:40:35]

should this be INVALID_HANDLE_VALUE?

[jschuh, 2014/03/05 17:52:03]

No. INVALID_HANDLE_VALUE can bite you because it aliases to the process
pseudo-handle. NULL should be used instead, except for when dealing with the
small number of Win16-derived APIs that require INVALID_HANDLE_VALUE (e.g.
CreateFile and friends).

   return TransportDIB::Map(duped);
 #elif defined(TOOLKIT_GTK)
   return TransportDIB::Map(dib_id.shmkey);
 #elif defined(OS_ANDROID)
   // On Android, Handles and Ids are the same underlying type.
   return TransportDIB::Map(dib_id);
 #else
   // On POSIX, TransportDIBs are always created in the browser, so we cannot map
   // one from a dib_id.
   return TransportDIB::Create(100 * 100 * 4, 0);
@@ skipping 144 matching lines @@
   for (ScopedVector<MockRenderProcessHost>::iterator it = processes_.begin();
        it != processes_.end(); ++it) {
     if (*it == host) {
       processes_.weak_erase(it);
       break;
     }
   }
 }
 
 }  // content