Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 181013014: Add quickcheck targets for modes, builds and arches. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add quickcheck targets for modes, builds and arches. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19686

Patch Set 1 #

Total comments: 3

Patch Set 2 : Ditch mips.optdebug change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M Makefile View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
PTAL
6 years, 9 months ago (2014-03-05 09:13:56 UTC) #1
Sven Panne
LGTM with a nit. https://codereview.chromium.org/181013014/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/181013014/diff/1/Makefile#newcode275 Makefile:275: mips mips.release mips.debug mips.optdebug: I ...
6 years, 9 months ago (2014-03-05 09:32:33 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/181013014/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/181013014/diff/1/Makefile#newcode275 Makefile:275: mips mips.release mips.debug mips.optdebug: On 2014/03/05 09:32:33, Sven Panne ...
6 years, 9 months ago (2014-03-05 11:31:08 UTC) #3
Jakob Kummerow
DBC. https://codereview.chromium.org/181013014/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/181013014/diff/1/Makefile#newcode275 Makefile:275: mips mips.release mips.debug mips.optdebug: On 2014/03/05 09:32:33, Sven ...
6 years, 9 months ago (2014-03-05 12:48:52 UTC) #4
Benedikt Meurer
Committed patchset #2 manually as r19686 (tree was closed).
6 years, 9 months ago (2014-03-06 10:05:38 UTC) #5
Jakob Kummerow
6 years, 9 months ago (2014-03-12 09:53:28 UTC) #6
Message was sent while issue was closed.
More DBC:

What exactly is the point of these targets? AFAICS "make foo.quickcheck" is just
short for "make foo.check TESTFLAGS=--quickcheck". Notably this is *not* the
same as the "foo" part of "make quickcheck", as foo.quickcheck builds and runs
full debug mode rather than optdebug.

So all this does compared to the usual foo.check targets is skip long-running
tests. IMHO this difference is not worth a separate target definition, the
similarity to "make quickcheck" is confusing, and this CL should be reverted.

Powered by Google App Engine
This is Rietveld 408576698